Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

fix: move access-list address and storage key from value and value_prev to word_rlc and word_rlc_prev in copy circuit #1073

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

silathdiir
Copy link

@silathdiir silathdiir commented Jan 4, 2024

Summary

Since the value_prev column should be deleted after refactor.

  • move access-list address from value column to word_rlc.
  • move access-list storage key from value_prev column to word_rlc_prev.
  • update table assignment and copy circuit.
  • the test case copy_circuit_valid_access_list could pass.
  • the RW lookups for access-list address and storage key could work.

Will test tx lookups with EIP-1559 PR #1030.


…` (deleted after refactor) columns to `word_rlc` and `word_rlc_prev` in copy circuit.
@silathdiir silathdiir changed the title fix: move access-list address and storage key from value and value_prev to word_rlc and word_rlc_prev in copy circuit [WIP] fix: move access-list address and storage key from value and value_prev to word_rlc and word_rlc_prev in copy circuit Jan 4, 2024
@silathdiir silathdiir changed the title [WIP] fix: move access-list address and storage key from value and value_prev to word_rlc and word_rlc_prev in copy circuit fix: move access-list address and storage key from value and value_prev to word_rlc and word_rlc_prev in copy circuit Jan 4, 2024
@lightsing
Copy link
Member

I will pick it in my pr, don't merge

@DreamWuGit
Copy link

DreamWuGit commented Jan 8, 2024

I will pick it in my pr, don't merge

this PR is base on old copy circuit(no hi lo word), LGTM, which is your pr ? @lightsing

@lispc lispc marked this pull request as draft January 8, 2024 05:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants