Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1544 #1592

Closed
wants to merge 2 commits into from
+2 −4
Closed

fix: #1544 #1592

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9d4ec6
fix #1544
Dalgerok Jan 22, 2025
4e5736c
Update CONTRIBUTING.md
Dalgerok Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
## Contributing

[fork]: /fork
[pr]: /compare
[style]: https://standardjs.com/
[code-of-conduct]: CODE_OF_CONDUCT.md

Expand All @@ -21,11 +19,11 @@ We'd also love PRs. If you're thinking of a large PR, we advise opening up an is

## Submitting a pull request

1. [Fork][fork] and clone the repository.
1. [Fork](https://github.com/scroll-tech/scroll/fork) and clone the repository.
2. Create a new branch: `git checkout -b my-branch-name`.
3. Make your change, add tests, and make sure the tests still pass.
4. Format your code in scroll home directory: `make lint && make fmt`
5. Push to your fork and [submit a pull request][pr].
5. Push to your fork and [submit a pull request](https://github.com/scroll-tech/scroll/compare).
6. Pat yourself on the back and wait for your pull request to be reviewed and merged.

Here are a few things you can do that will increase the likelihood of your pull request being accepted:
Expand Down