-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support local prover && multiple task types #54
base: main
Are you sure you want to change the base?
Conversation
yiweichi
commented
Jan 5, 2025
•
edited
Loading
edited
- Support local prover
- Support multiple task types in one prover process
Actually, I think we should combine this repo and prover repo to small one, let this repo become a crate of prover. wdyt @Thegaram the layout maybe like this
|
for the easily usage, we should simpfy some config option like |
Co-authored-by: georgehao <[email protected]>
…l-tech/scroll-proving-sdk into feat-integrate-proving-sdk
if self.circuit_types.contains(&CircuitType::Bundle) | ||
|| self.circuit_types.contains(&CircuitType::Batch) | ||
{ | ||
prover_types.push(CircuitType::Batch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these two merged into one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a lagacy from coordinator's side. we used to not split batch prover and bundle prover. So from coordinator's view, there are only 2 types of prover (chunk prover and batch prover).
@@ -35,7 +35,7 @@ pub struct Prover { | |||
impl Prover { | |||
pub async fn run(self) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we spin up n
workers that each can support all prover types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's true. but we can also spin up n workers that can only prove batch or chunk.
Side note: Once this is merged, please submit a PR to https://github.com/Sindri-Labs/sindri-scroll-sdk (should be just a few simple fixes). |
We discussed this offline, but just so that we have info here:
|
Co-authored-by: Péter Garamvölgyi <[email protected]>
…erType to_u8 This reverts commit 575423f. refactor: ProverProviderType to_u8
3ba1ee9
to
4ae7687
Compare