feat: add system config consensus to deprecate clique #72
Conversation
ranchalp
force-pushed
the
system-contract
branch
4 times, most recently
from
ececf8e to
e5f797e
Compare
ranchalp
force-pushed
the
system-contract
branch
from
e5f797e to
9cfaad5
Compare
| */ | ||
| contract SystemSignerRegistry is Ownable { | ||
| struct Signer { | ||
| uint64 startBlock; |
There was a problem hiding this comment.
Didn't we decide against having the startBlock here?
| address signer; | ||
| } | ||
|
|
||
| Signer[] private signers; |
There was a problem hiding this comment.
| Signer[] private signers; | |
| mapping (address => bool) public isAuthorizedSigner; |
There was a problem hiding this comment.
Need to consider how l2geth will read this contract.
- If it just polls the latest state asking "am I authorized?", then a mapping is suitable.
- If it just polls the latest state asking "what is the list of current authorized signers?", then an array is suitable.
- If it fetches events, then I'd still go with mapping.
There was a problem hiding this comment.
will we have multiple authorized signer in the same time?
| * The getSigners() function returns parallel arrays for block numbers and addresses, | ||
| * | ||
| */ | ||
| contract SystemSignerRegistry is Ownable { |
There was a problem hiding this comment.
Do we want to make this upgradable?
| * The getSigners() function returns parallel arrays for block numbers and addresses, | ||
| * | ||
| */ | ||
| contract SystemSignerRegistry is Ownable { |
There was a problem hiding this comment.
Why not model this after OP's? https://github.com/ethereum-optimism/optimism/blob/develop/packages/contracts-bedrock/src/L1/SystemConfig.sol (see for example _setUnsafeBlockSigner).
@zimpha what do you think about storing multiple configs here (including gas coefficients, max gas limit, etc.)? Or is that too expensive gas-wise?
There was a problem hiding this comment.
we can add these config here, we can pack related parameters into single uint256. Then the gas overhead will be minimum.
In conjunction with go-ethereum#1102.