feat: e2e test in GitHub action #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frisitano
requested changes
Jul 21, 2025
There was a problem hiding this comment.
I have left some general comments inline. I think we should restructure this crate a bit. Firstly the crate should be a workspace member, this can be achieved by creating the crate using cargo new tests --lib. We should then have the following directory structure:
tests/
src/
tests/
Cargo.toml
All of the logic currently in common should go inside of src/. The files in integration can be moved to tests/integration.
Regarding the comments left inline I will wait for your. feedback.
colinlyguo
force-pushed
the
e2e-test-in-github-CI
branch
from
3524d16 to
f093612
Compare
colinlyguo
force-pushed
the
e2e-test-in-github-CI
branch
from
f093612 to
794c026
Compare
frisitano
reviewed
Jul 24, 2025
frisitano
previously approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.