Skip to content

feat: support directly forward transactions to sequencer #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 28, 2025

Conversation

yiweichi
Copy link
Member

@yiweichi yiweichi commented Jun 27, 2025

Reth counterpart of l2geth scroll-tech/go-ethereum#1208.
Related rollup-node PR: scroll-tech/rollup-node#189

Implemented a SequencerClient, which will help to forward transaction to sequencer's RPC directly(support both http and ws). Whether a transaction forwarding succeed or not, the transaction will be added to local transaction pool.

Copy link

codspeed-hq bot commented Jun 27, 2025

CodSpeed Performance Report

Merging #265 will not alter performance

Comparing feat-forward-tx-to-sequencer (723bf8b) with scroll (d250986)

Summary

✅ 77 untouched benchmarks

@yiweichi yiweichi changed the title feat: support forward transaction to sequencer feat: support directly forward transactions to sequencer Jul 3, 2025
@yiweichi yiweichi requested review from frisitano and greged93 July 4, 2025 09:02
frisitano
frisitano previously approved these changes Jul 8, 2025
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Left a question inline.

@frisitano
Copy link
Collaborator

Please fix CI and then feel free to merge.

@yiweichi yiweichi force-pushed the feat-forward-tx-to-sequencer branch from fb048ca to 499e9ae Compare July 17, 2025 12:24
@greged93
Copy link
Collaborator

@yiweichi can we merge this?

@yiweichi
Copy link
Member Author

@yiweichi can we merge this?

will merge soon, just need to add a testing.

@yiweichi yiweichi force-pushed the feat-forward-tx-to-sequencer branch 3 times, most recently from 3c5e0ab to f3d9120 Compare July 25, 2025 10:50
@yiweichi yiweichi force-pushed the feat-forward-tx-to-sequencer branch 2 times, most recently from 9baf144 to 9e11ec9 Compare July 25, 2025 10:58
@yiweichi yiweichi force-pushed the feat-forward-tx-to-sequencer branch from 9e11ec9 to 9c750c0 Compare July 25, 2025 11:04
@yiweichi yiweichi requested a review from frisitano July 25, 2025 14:58
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of modifying the constructor for EthTransactionValidatorBuilder we should use the pre-existing with_local_transactions_config to set the LocalTransactionConfig. This minimises the diff with upstream which is a priority for us.

@yiweichi yiweichi requested a review from frisitano July 28, 2025 07:21
frisitano
frisitano previously approved these changes Jul 28, 2025
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left some comments inline around logging. We should prefix the target with scroll:: such that when we filter logs using RUST_LOG=scroll=trace we can correctly filter the appropriate target. Otherwise, these logs may get lost.

Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yiweichi yiweichi merged commit 18bff3a into scroll Jul 28, 2025
38 checks passed
@yiweichi yiweichi deleted the feat-forward-tx-to-sequencer branch July 28, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants