feat(L1 follower and rollup verifier): support CodecV7 in L1 follower mode and rollup verifier #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s submitted in one transaction
…single transactions
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…1-follower-mode-update-da-codec
…atch within a set of batches
colinlyguo
reviewed
Jan 25, 2025
| } | ||
| blobVersionedHash := common.Hash(kzg4844.CalcBlobHashV1(sha256.New(), &c)) | ||
| if blobVersionedHash != blobHash { | ||
| return nil, fmt.Errorf("blobVersionedHash from blob source is not equal to versionedHash from tx, correct versioned hash: %s, fetched blob hash: %s", blobHash.Hex(), blobVersionedHash.String()) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("blobVersionedHash from blob source is not equal to versionedHash from tx, correct versioned hash: %s, fetched blob hash: %s", blobHash.Hex(), blobVersionedHash.String()) | |
| return nil, fmt.Errorf("blobVersionedHash from blob source is not equal to versionedHash from tx, correct versioned hash: %s, fetched blob hash: %s", blobHash.Hex(), blobVersionedHash.Hex()) |
|
|
||
| entries = append(entries, commitBatchDAEntries...) | ||
| lastCommitEvents = nil | ||
| lastCommitTransactionHash = emptyHash |
There was a problem hiding this comment.
What's the difference between using emptyHash and common.Hash{}? e.g. reducing the allocation overhead?
| for i, commitEvent := range commitEvents { | ||
| // sanity check commit events from batches submitted in the same L1 transaction | ||
| if commitEvent.TxHash() != firstCommitEvent.TxHash() { | ||
| return nil, fmt.Errorf("commit events have different tx hashes, batch index: %d, tx: %s - batch index: %d, tx: %s", firstCommitEvent.BatchIndex().Uint64(), firstCommitEvent.TxHash().Hex(), commitEvent.BatchIndex().Uint64(), commitEvent.TxHash().Hex()) |
There was a problem hiding this comment.
What cases will fail these checks?
| return nil, fmt.Errorf("failed to decode DA, batch index: %d, err: %w", commitEvent.BatchIndex().Uint64(), err) | ||
| } | ||
| case 7: | ||
| if i >= len(args.BlobHashes) { |
There was a problem hiding this comment.
is this added for completeness sake?
colinlyguo
approved these changes
Jan 25, 2025
| return nil, fmt.Errorf("failed to get commit batch da: %v, err: %w", rollupEvent.BatchIndex().Uint64(), err) | ||
|
|
||
| // if this is a different commit transaction, we need to create a new DA | ||
| if lastCommitTransactionHash != commitEvent.TxHash() && len(lastCommitEvents) > 0 { |
There was a problem hiding this comment.
this is a bit unintuitive at first glance, so do other places of calling getAndAppendCommitBatchDA. but I cannot think of a better way, too. it's due to multiple commit batch events belonging to a same transaction (with multiple blobs).
…1-follower-mode-update-da-codec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
...
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?