Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secp256k1 and sha256_extend mocks + refactor #826

Merged

Conversation

mcalancea
Copy link
Collaborator

@mcalancea mcalancea commented Feb 4, 2025

  • all precompiles have the same interface as their counter-parts in sp1; the secp256k1 curve ops are backed by the secp crate.
  • integrates appropriate dummy circuits for precompiles into the zkvm
  • added utils.rs with some utilities for safely manipulating memory segments of the VM
  • tested the compatibility of the syscalls (+ keccak, done previously) with sp1 (see the syscalls.rs example file).
  • extended the docs pasted from sp1

Aurel has reviewed an earlier version of this here.

@mcalancea mcalancea requested a review from lispc February 4, 2025 16:54
@mcalancea mcalancea enabled auto-merge February 7, 2025 10:32
@mcalancea mcalancea added this pull request to the merge queue Feb 7, 2025
Merged via the queue into scroll-tech:master with commit 4d4dd3d Feb 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants