-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for benchmarks #822
Open
matthiasgoergens
wants to merge
20
commits into
master
Choose a base branch
from
matthias/sproll-support-minimal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
325736c
Heap and stack sizes in kiB and MiB
matthiasgoergens 5bc10b2
Support sproll proving
matthiasgoergens 2357099
Merge branch 'master' into matthias/sproll-proof
matthiasgoergens ca37dae
Minimise diff
matthiasgoergens 5eda52c
Less spam when running `e2e`
matthiasgoergens acf5453
Merge branch 'matthias/less-spam' into matthias/sproll-proof
matthiasgoergens 558bee0
Only log once
matthiasgoergens d1d447b
Only complain about threads once
matthiasgoergens 784e9e6
Merge branch 'matthias/less-spam-2' into matthias/sproll-proof
matthiasgoergens 2f08224
Show unused operations, too
matthiasgoergens dfd8440
Merge remote-tracking branch 'origin/master' into matthias/sproll-proof
matthiasgoergens 172d2fd
All in Hex
matthiasgoergens 1014049
Display in hex
matthiasgoergens b27f107
Simpler
matthiasgoergens ec4d231
More hex
matthiasgoergens 68c39c7
Merge branch 'master' into matthias/sproll-proof
matthiasgoergens 03ade60
Merge remote-tracking branch 'origin/master' into matthias/sproll-proof
matthiasgoergens 8b53a70
Merge remote-tracking branch 'origin/matthias/sproll-proof' into matt…
matthiasgoergens be7f34f
Minimise diff
matthiasgoergens 92c8ca0
Merge branch 'master' into matthias/sproll-support-minimal
matthiasgoergens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,6 +45,7 @@ pub struct EmulationResult { | |
pi: PublicValues<u32>, | ||
} | ||
|
||
// TODO(Matthias): handle hints properly. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is something to fix soon. But I don't know enough at the moment. It's definitely broken in |
||
fn emulate_program( | ||
program: Arc<Program>, | ||
max_steps: usize, | ||
|
@@ -574,8 +575,18 @@ fn debug_memory_ranges(vm: &VMState, mem_final: &[MemFinalRecord]) { | |
format_segments(vm.platform(), handled_addrs.iter().copied()) | ||
); | ||
|
||
for addr in &accessed_addrs { | ||
assert!(handled_addrs.contains(addr), "unhandled addr: {:?}", addr); | ||
let unhandled: BTreeSet<_> = accessed_addrs | ||
.iter() | ||
.filter(|addr| !handled_addrs.contains(addr)) | ||
.collect(); | ||
|
||
// TODO(Matthias): this should be an assert, but it's currently broken, because our caller doesn't handle hints. | ||
hero78119 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if !unhandled.is_empty() { | ||
tracing::warn!( | ||
"unhandled addr: {:?} to {:?}", | ||
unhandled.first(), | ||
unhandled.last() | ||
); | ||
} | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hex is easier to read here (because we use round numbers, only when expressed in powers of 2), and it's also how we specify these numbers in our linker script etc.