Standard library support for guests #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from #631
| @@ -1,2 +1,3 @@ | |||
| [toolchain] | |||
| channel = "nightly-2024-12-06" | |||
| components = ["rust-src"] | |||
There was a problem hiding this comment.
We need the sources for build-std.
ceno_rt/.cargo/config.toml
Outdated
There was a problem hiding this comment.
Actually, it moved to examples/.cargo/config.toml.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
Extracted from #759
matthiasgoergens
requested review from
icemelon,
kunxian-xia,
hero78119 and
naure
lispc
approved these changes
Dec 18, 2024
|
I'm merging this now, so we can build on it. But I will do a follow up PR that addresses the duplication of code snippets for running in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard library support for guests works, but this PR needs some polishing and depends on a lot of other PRs that should go in first, to make this one easier to review. Nevertheless, you can have a look and try this one out, if you want.