Enable clippy check for Cargo.toml files (#401)

One of the benefits is that we get warned, when we depend on multiple
version of the same crate. That's inefficient and can lead to subtle
errors.

As an example, you can run this to see the different versions of `syn`:

```console
$ cargo tree --invert  syn
error: There are multiple `syn` packages in your project, and the specification `syn` is ambiguous.
Please re-run this command with one of the following specifications:
  [email protected]
  [email protected]
```

And then be more specific to see the offenders that still depend on the
old version of `syn`:

```console
$ cargo tree --invert syn@1
syn v1.0.109
└── unroll v0.1.5 (proc-macro)
    ├── plonky2 v0.2.2
    │   └── mpcs v0.1.0 (/home/matthias/scroll/prog/ceno6/mpcs)
    │       └── ceno_zkvm v0.1.0 (/home/matthias/scroll/prog/ceno6/ceno_zkvm)
    │   [dev-dependencies]
    │   └── poseidon v0.1.0 (/home/matthias/scroll/prog/ceno6/poseidon)
    │       ├── ff_ext v0.1.0 (/home/matthias/scroll/prog/ceno6/ff_ext)
    │       │   ├── ceno_zkvm v0.1.0 (/home/matthias/scroll/prog/ceno6/ceno_zkvm)
    │       │   ├── mpcs v0.1.0 (/home/matthias/scroll/prog/ceno6/mpcs) (*)
    │       │   ├── multilinear_extensions v0.1.0 (/home/matthias/scroll/prog/ceno6/multilinear_extensions)
    │       │   │   ├── ceno_zkvm v0.1.0 (/home/matthias/scroll/prog/ceno6/ceno_zkvm)
    │       │   │   ├── mpcs v0.1.0 (/home/matthias/scroll/prog/ceno6/mpcs) (*)
    │       │   │   └── sumcheck v0.1.0 (/home/matthias/scroll/prog/ceno6/sumcheck)
    │       │   │       └── ceno_zkvm v0.1.0 (/home/matthias/scroll/prog/ceno6/ceno_zkvm)
    │       │   ├── sumcheck v0.1.0 (/home/matthias/scroll/prog/ceno6/sumcheck) (*)
    │       │   └── transcript v0.1.0 (/home/matthias/scroll/prog/ceno6/transcript)
    │       │       ├── ceno_zkvm v0.1.0 (/home/matthias/scroll/prog/ceno6/ceno_zkvm)
    │       │       ├── mpcs v0.1.0 (/home/matthias/scroll/prog/ceno6/mpcs) (*)
    │       │       └── sumcheck v0.1.0 (/home/matthias/scroll/prog/ceno6/sumcheck) (*)
    │       ├── mpcs v0.1.0 (/home/matthias/scroll/prog/ceno6/mpcs) (*)
    │       └── transcript v0.1.0 (/home/matthias/scroll/prog/ceno6/transcript) (*)
    ├── plonky2_field v0.2.2
    │   └── plonky2 v0.2.2 (*)
    └── poseidon v0.1.0 (/home/matthias/scroll/prog/ceno6/poseidon) (*)
```

For now I've just whitelisted the existing offenders, but in the future
a new PR can work on shrinking that list.

---------

Co-authored-by: Zhang Zhuo <[email protected]>

Cargo.toml

@@ -14,8 +14,12 @@ members = [
 resolver = "2"
 
 [workspace.package]
+categories = ["cryptography", "zk", "blockchain", "ceno"]
 edition = "2021"
+keywords = ["cryptography", "zk", "blockchain", "ceno"]
 license = "MIT OR Apache-2.0"
+readme = "README.md"
+repository = "https://github.com/scroll-tech/ceno"
 version = "0.1.0"
 
 [workspace.dependencies]

ceno_emul/Cargo.toml

@@ -1,7 +1,12 @@
 [package]
+categories.workspace = true
+description = "A Risc-V emulator for Ceno"
 edition.workspace = true
+keywords.workspace = true
 license.workspace = true
 name = "ceno_emul"
+readme.workspace = true
+repository.workspace = true
 version.workspace = true
 
 [dependencies]

ceno_emul/src/lib.rs

@@ -1,3 +1,4 @@
+#![deny(clippy::cargo)]
 mod addr;
 pub use addr::*;
 

ceno_rt/Cargo.toml

@@ -1,7 +1,12 @@
 [package]
+categories.workspace = true
+description = "Ceno runtime library"
 edition.workspace = true
+keywords.workspace = true
 license.workspace = true
 name = "ceno_rt"
+readme = "README.md"
+repository.workspace = true
 version.workspace = true
 
 [dependencies]

ceno_rt/src/lib.rs

@@ -1,3 +1,4 @@
+#![deny(clippy::cargo)]
 #![feature(strict_overflow_ops)]
 #![no_std]
 

ceno_zkvm/Cargo.toml

@@ -1,7 +1,12 @@
 [package]
+categories.workspace = true
+description = "Ceno ZKVM"
 edition.workspace = true
+keywords.workspace = true
 license.workspace = true
 name = "ceno_zkvm"
+readme.workspace = true
+repository.workspace = true
 version.workspace = true
 
 [dependencies]

ceno_zkvm/src/lib.rs

@@ -1,3 +1,4 @@
+#![deny(clippy::cargo)]
 #![feature(box_patterns)]
 #![feature(stmt_expr_attributes)]
 #![feature(variant_count)]

clippy.toml

@@ -0,0 +1,10 @@
+# TODO(Matthias): review and see which exception we can remove over time.
+# Eg removing syn is blocked by ark-ff-asm cutting a new release
+# (https://github.com/arkworks-rs/algebra/issues/813) amongst other things.
+allowed-duplicate-crates = [
+  "syn",
+  "windows-sys",
+  "regex-automata",
+  "regex-syntax",
+  "itertools",
+]

examples-builder/Cargo.toml

@@ -1,5 +1,9 @@
 [package]
+categories.workspace = true
+description = "Build scripts for ceno examples"
 edition.workspace = true
+keywords.workspace = true
 license.workspace = true
 name = "ceno-examples"
+repository.workspace = true
 version.workspace = true

examples-builder/src/lib.rs

@@ -1 +1,2 @@
+#![deny(clippy::cargo)]
 include!(concat!(env!("OUT_DIR"), "/vars.rs"));

examples/Cargo.toml

@@ -1,6 +1,7 @@
 [package]
 edition = "2021"
 name = "examples"
+readme = "README.md"
 resolver = "2"
 version = "0.1.0"
 

ff_ext/Cargo.toml

@@ -1,7 +1,12 @@
 [package]
+categories.workspace = true
+description = "Extra functionality for the ff ((finite fields) crate"
 edition.workspace = true
+keywords.workspace = true
 license.workspace = true
 name = "ff_ext"
+readme.workspace = true
+repository.workspace = true
 version.workspace = true
 
 [dependencies]

ff_ext/src/lib.rs

@@ -1,3 +1,4 @@
+#![deny(clippy::cargo)]
 pub use ff;
 use ff::FromUniformBytes;
 use goldilocks::SmallField;

mpcs/Cargo.toml

@@ -1,7 +1,12 @@
 [package]
+categories.workspace = true
+description = "Multilinear Polynomial Commitment Scheme"
 edition.workspace = true
+keywords.workspace = true
 license.workspace = true
 name = "mpcs"
+readme.workspace = true
+repository.workspace = true
 version.workspace = true
 
 [dependencies]

mpcs/src/lib.rs

@@ -1,3 +1,4 @@
+#![deny(clippy::cargo)]
 use ff_ext::ExtensionField;
 use itertools::Itertools;
 use multilinear_extensions::mle::DenseMultilinearExtension;

multilinear_extensions/Cargo.toml

@@ -1,7 +1,12 @@
 [package]
+categories.workspace = true
+description = "Multilinear extensions for the Ceno project"
 edition.workspace = true
+keywords.workspace = true
 license.workspace = true
 name = "multilinear_extensions"
+readme.workspace = true
+repository.workspace = true
 version.workspace = true
 
 [dependencies]

multilinear_extensions/src/lib.rs

@@ -1,3 +1,4 @@
+#![deny(clippy::cargo)]
 pub mod mle;
 pub mod util;
 pub mod virtual_poly;

poseidon/Cargo.toml

@@ -1,7 +1,12 @@
 [package]
+categories.workspace = true
+description = "Poseidon hash function"
 edition.workspace = true
+keywords.workspace = true
 license.workspace = true
 name = "poseidon"
+readme.workspace = true
+repository.workspace = true
 version.workspace = true
 
 [dependencies]

poseidon/src/lib.rs

@@ -1,3 +1,4 @@
+#![deny(clippy::cargo)]
 extern crate core;
 
 pub(crate) mod constants;

sumcheck/Cargo.toml

@@ -1,7 +1,12 @@
 [package]
+categories.workspace = true
+description = "Sumcheck protocol implementation"
 edition.workspace = true
+keywords.workspace = true
 license.workspace = true
 name = "sumcheck"
+readme.workspace = true
+repository.workspace = true
 version.workspace = true
 
 [dependencies]

sumcheck/src/lib.rs

@@ -1,3 +1,4 @@
+#![deny(clippy::cargo)]
 #[cfg(feature = "non_pow2_rayon_thread")]
 pub mod local_thread_pool;
 mod macros;

transcript/Cargo.toml

@@ -1,7 +1,12 @@
 [package]
+categories.workspace = true
+description = "Transcript generation for Ceno"
 edition.workspace = true
+keywords.workspace = true
 license.workspace = true
 name = "transcript"
+readme.workspace = true
+repository.workspace = true
 version.workspace = true
 
 [dependencies]

transcript/src/lib.rs

@@ -1,3 +1,4 @@
+#![deny(clippy::cargo)]
 //! This repo is not properly implemented
 //! Transcript APIs are placeholders; the actual logic is to be implemented later.
 #![feature(generic_arg_infer)]