Feat/Remove ZK from Spartan Backend #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roof struct." This reverts commit 4b160ca.
kunxian-xia
reviewed
Dec 9, 2024
Collaborator
kunxian-xia
left a comment
kunxian-xia
left a comment
There was a problem hiding this comment.
Looks good to me except that we need to remove the codes in PolyEvalProof::prove() / verify().
Collaborator
Author
Removed! |
kunxian-xia
approved these changes
Dec 10, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
* Reversable: temporarily remove non-compiling parts * Remove PCS and add Goldilocks * Recover intermediate proofs * Recover intermediate proofs * Remove elliptic group definition * Remove remnant ristretto255 * Remove comment blocks * Correct goldilocks implementation * Make workflow pass * Remove extra space * Remove comment blocks * Correct comment blocks * Correct arithmetics * Recover SNARK verify checks * Recover sumcheck instance verification check * Comment out non-existent binaries. * Remove unused binaries * Graft in ceno-goldilocks * Modify pow fn * Add degree2 extension of goldilocks. Convert to ceno-goldilocks * Migrate to generic instead of base field * Migrate to generic instead of base field * Migrate to generic instead of base field * Remove unnecessary parameter specification * Add deserialize trait bound * fmt * Resolve conflicts/duplicates/dep versioning from merge * fmt * fmt * Correct itertools version * Restore transcript consistency * fmt * Code improvement * Code improvement * Code improvement * Code improvement * Import ceno-goldilocks main branch * fmt * Reuse Goldilocks random * Add basefield arithmetics * fmt * Use degree 2 ext for soundness * Specify output * Correct BaseField trait bound * Improve arithmetic definition * Reorder arithmetic definition * Add arithmetic traits * Feat/Remove ZK from Spartan Backend (#53) --------- Co-authored-by: Yuncong Zhang <[email protected]> Co-authored-by: Matthias Goergens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SumcheckInstanceProofeverywhere, replacingZKSumcheckInstanceProof.