-
Notifications
You must be signed in to change notification settings - Fork 1
Add the basefold recursive verifier. #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yczhangsjtu
wants to merge
78
commits into
main
Choose a base branch
from
cyte/fix-query-phase
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ceno-recursion-verifier into cyte/fix-query-phase
kunxian-xia
reviewed
Jun 25, 2025
* comment out * wip * hash read/write unit test passed * wip2 * add inv_2 to input stream * Fix memory out of bound problem * update Cargo.lock * Avoid providing two-adic generators inverses by hint * Replace idx_bits by num2bits_f * Replace idx_len by max_num_vars + rate log * Change index bits to small endian * Try fixing new index check * Fix new index check * Sub one from index len * Identified the cause * Fix index out of bound error * Change comment * Add native verify test * Fix evals shape error * Fix mmcs verify failure * Remove some print lines * fmt * Supply all hints * Fix new index compute * Fix ext mmcs verify dimension * Slice idx bits in ext mmcs verify * Some small fixes * right shift by hint * Fix verifier_folding_coeffs_level * Successfully run to first checkpoint * Fails at last line * Identified unimplemented function build_eq_x_r_vec_sequential_with_offset * batch verifier query phase test passes * Print the cycle count --------- Co-authored-by: Yuncong Zhang <[email protected]>
* [Upgrade] ZKVMProof Verifier Update (#31) * Remove index reversal * Add a cycle tracker * Delete a loop * Better casting * Change verifier logic * Finish opcdoe proof verification debugging * Finish debugging table proof verification * Debug verifier * Finish debugging updated verifier * Remove unnecessary table proof fields * Remove unnecessary parsing * Update Plonky3 * Migrate away from temporary build branch * Switch ceno reliance * Fix compilation errors due to out of date code * Update test query phase batch * Fix query opening proof * Implement basefold proof variable * Update query phase verifier input * Preparing test data for query phase with updated code * Implement basefold proof transform * Prepare query phase verifier input * Prepare query phase verifier input * Fix final message access * Switch ceno reliance to small field support * basefold verifier for one matrix (#35) * wip * wip2 * wip3 * fix test * fix * fmt * fri part of verifying basefold proof for 1 matrix passed * sumcheck part 1 * sumcheck part 2 * sumcheck part 3 * cleanup * more cleanups --------- Co-authored-by: Ray Gao <[email protected]> Co-authored-by: xkx <[email protected]>
Feat: basefold verifier for multiple matrices
* Switch ceno reliance * Fix compilation errors due to out of date code * Update test query phase batch * Fix query opening proof * Implement basefold proof variable * Update query phase verifier input * Preparing test data for query phase with updated code * Implement basefold proof transform * Prepare query phase verifier input * Prepare query phase verifier input * Fix final message access * Switch ceno reliance to small field support * Create basefold verifier function * Check final message sizes * Fix final message size * Fix final message size * Check query opening proof len * Compute total number of polys * Sample batch coeffs * Compute max_num_var * Write sumcheck messages and commits to transcript * Write final message to transcript * Complete the code for batch verifier * Add verifier test * Try to fix some compilation errors in e2e * Connecting pcs with e2e * Fix some issues after merge * Make compilation pass temporarily * Make test pass before query phase * Supply the permutation and make the random case pass * Try fixing transcript inconsistency * Use bin to dec le * Add pow witness * Basefold verifier passes for simple case * Update dependency * Basefold verifier passes decreasing and random batches * update ceno dependencies * comment out patch * refactor * the computation of max_num_var is simplified * put perm to RoundVariable * remove debug routines * rename * clean * cleanup * ignore e2e test --------- Co-authored-by: kunxian xia <[email protected]>
This was
linked to
issues
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the MMCS verifier and basefold recursive verifier.