Implement field option to set as nullable for create input type #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
============================================
+ Coverage 84.39% 84.43% +0.04%
- Complexity 647 649 +2
============================================
Files 75 75
Lines 1878 1883 +5
============================================
+ Hits 1585 1590 +5
Misses 293 293
Continue to review full report at Codecov.
|
robertvansteen
requested changes
Dec 17, 2018
| @@ -49,8 +49,8 @@ protected function getFillableFields(): Collection | |||
| $fields = parent::getFillableFields(); | |||
| $defaults = $this->model->getAttributes(); | |||
|
|
|||
| return $fields->map(function (Field $field, $key) use ($defaults) { | |||
| if (in_array($key, array_keys($defaults))) { | |||
There was a problem hiding this comment.
This should still be there. nullableOnCreate should just be an addition for more complex use cases where the default will be set by an observer.
robertvansteen
changed the title
erikgaal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78