Skip to content

Put back in "Merge pull request #489 from adroitwhiz/touching-white-fixes" #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fsih
Copy link
Contributor

@fsih fsih commented Aug 27, 2020

Reverts #684

It was totally my fault, I had a paren in the wrong place >_<
(compare to pull/676)

@fsih fsih force-pushed the revert-684-revert-676-revert-674-revert-673-revert-660-revert-489 branch from fdbd1ad to e2fd7cc Compare August 27, 2020 20:56
@fsih fsih force-pushed the revert-684-revert-676-revert-674-revert-673-revert-660-revert-489 branch from e2fd7cc to ffa53a6 Compare August 27, 2020 20:58
@fsih fsih changed the title Revert "Revert "Put back in "Merge pull request #489 from adroitwhiz/touching-white-fixes""" Put back in "Merge pull request #489 from adroitwhiz/touching-white-fixes" Aug 27, 2020
@fsih fsih requested a review from cwillisf August 27, 2020 21:04
Copy link
Contributor

@cwillisf cwillisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry I missed the paren placement in my last review.
I do like moving the tolerance value into a constant!

@fsih fsih merged commit a7df2b2 into develop Aug 27, 2020
@fsih fsih deleted the revert-684-revert-676-revert-674-revert-673-revert-660-revert-489 branch August 27, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants