Made npm run dist on Linux build an app image.
#473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in scratchfoundation#117, there is no bandwidth for official Linux releases, but this at least makes getting a working Linux binary from source quite easy. An app image is a self-contained binary. Unlike deb, rpm and flatpak, creating an app image doesn't seem to require installing any external tooling.
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Make
npm run diston Linux build an app image instead of just erroring out.Reason for Changes
As discussed in #117, there is no bandwidth for official Linux releases, but this at least makes getting a working Linux binary from source quite easy.
An app image is a self-contained binary.
Unlike deb, rpm and flatpak, creating an app image doesn't seem to require installing any external tooling.
(Also tagging related: #416)