feat: [UEPR-268] change canvas svg to rgenerate when containing container resizes #3355
+21
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwillisf
reviewed
Jun 12, 2025
| Blockly.hideChaffOnResize(true); | ||
| Blockly.svgResize(mainWorkspace); | ||
| }); | ||
| mainWorkspace.setResizeHandlerWrapper(workspaceResizeHandler); |
There was a problem hiding this comment.
The old code kept track of this handler and would remove it in the workspace's dispose() function. Do we need to do something equivalent in the new code?
There was a problem hiding this comment.
You are right. I added logic for disconnecting the observer
|
Also, the test failure appears to be due to the browser failing to load the JS file(s). It seems like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
UEPR-268
Proposed Changes
Currently the canvas svg regenerates when window resizes. However new features require to resize the editor without changing the window size. This cause the canvas to be bigger or smaller than the
divthat contains it. This changes make it so the canvas regenerates when the containingdivchanges size.