Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Able to search in page content too #199

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Freebien
Copy link
Contributor

@Freebien Freebien commented Feb 8, 2017

A little hack to add a handy functionality.
We are now able to find a page by searching in all words in title AND content

Also used a variable to get all characters to remove. So it can be easier to use it as a Configuration parameter.

Best I could do for now.

Fabien Kleinbourg and others added 2 commits February 8, 2017 14:33
@scragg0x
Copy link
Owner

I'm not sure how I feel about this. It seems to be a very inefficient way to search the wiki. I would think if a realms admin wanted better search functionality they would use Elasticsearch or maybe Whoosh.

@Freebien
Copy link
Contributor Author

It is not efficient if there is a lot of content.
I'll try to add a new advanced search page to choose the fields you want to search on !

But it's really fast on little environments with not that much pages.

@roycepope
Copy link

Hey @Freebien I love your little hack here! I added it to mine as well. I was wondering if there was a way to make the page content search not be case sensitive. Is this possible? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants