forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 0
Scrabsha/html errors #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
scrabsha
wants to merge
12
commits into
master
Choose a base branch
from
scrabsha/html-errors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b33ccc3
Add the -Z html-output option and ui header command
be3af9f
wait, wtf
7e718d5
Fix the whole thing, add a comment too
ae79e44
Fix typo, remove old fixme
scrabsha de28762
Restructure code a bit, avoid an allocation
512d0b9
Remove margins, make raw strings
88614ef
Add test file for html output
e2e20b1
Enable UTF-8
6757dbd
Use split_inclusive to eliminate some calls to write
5f212de
Put the escaper in its own state machine
6e27b89
Don't report an error if we succeeded in writing at something
8e064c1
Use the segment index instead of a `first` boolean
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In practice I don't know if it actually matters (I am assuming that you've run tests and observed it work; I haven't tried to work on the compiler before and so haven't actually downloaded or run this myself), but I think this clause loses the current
.next()
segment if it is not able to write intoself.inner
, so a retry would skip it. If it works as-is, then I wouldn't worry about it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it is not a problem if we don't write the current
.next()
, as long as we exit early and return the correct amount of bytes we actually wrote.But the good news is that you're highlighting the fact that we should not return an error if we wrote something to the sink. I do need to fix that.