-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WJ-1293] Support wjfiles through new router service #2283
base: develop
Are you sure you want to change the base?
Conversation
Also remove the old ftml dependabot entry.
Probably not actually used, but we can add it anyways.
Put the S3 entries together.
e55b290
to
186a099
Compare
What a pain in the ass.
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
15850647 | Triggered | Generic Private Key | 818bb69 | wws/misc/self-signed-key.pem | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This is not truly a secret, but a self-signed key for use locally only. In dev and prod, TLS termination will be provided by the host and so TLS secrets are not actually really managed by the application. |
Domain seems busted?
This issue adds "wws": Wilson's Web Server, a replacement for a fronting nginx instance which is able to carry out the routing needed given our need for host lookup and header additions. For instance, visiting
scpwiki.dev
needs to be referenced to find the site slug and ID, and passed as internal headers for framerail to consume.WWS also is where the logic for wjfiles lives, appropriately fetching data from DEEPWELL as needed. However, data will be cached (such as host/domain information) in Redis. Framerail's logic has been updated to accomodate this new topology.