Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WJ-1293] Support wjfiles through new router service #2283

Draft
wants to merge 243 commits into
base: develop
Choose a base branch
from

Conversation

emmiegit
Copy link
Member

This issue adds "wws": Wilson's Web Server, a replacement for a fronting nginx instance which is able to carry out the routing needed given our need for host lookup and header additions. For instance, visiting scpwiki.dev needs to be referenced to find the site slug and ID, and passed as internal headers for framerail to consume.

WWS also is where the logic for wjfiles lives, appropriately fetching data from DEEPWELL as needed. However, data will be cached (such as host/domain information) in Redis. Framerail's logic has been updated to accomodate this new topology.

@emmiegit emmiegit self-assigned this Feb 24, 2025
Copy link

gitguardian bot commented Mar 5, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
15850647 Triggered Generic Private Key 818bb69 wws/misc/self-signed-key.pem View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@emmiegit
Copy link
Member Author

emmiegit commented Mar 5, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secret in your pull request

🛠 Guidelines to remediate hardcoded secrets

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

This is not truly a secret, but a self-signed key for use locally only. In dev and prod, TLS termination will be provided by the host and so TLS secrets are not actually really managed by the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant