Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@ name: lint
on:
pull_request:
branches: [main]
push:
branches: [main]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
ruff-mypy:
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,19 @@ name: test
on:
pull_request:
branches: [main]
push:
branches: [main]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
unit-integration-golden:
runs-on: [self-hosted, linux, x64]
strategy:
matrix:
python-version: ["3.11", "3.12"]
# 3.12 on PR; full matrix on tag releases. Was [3.11, 3.12] on every
# PR; doubled minutes without catching anything PRs were breaking.
python-version: ${{ github.event_name == 'pull_request' && fromJson('["3.12"]') || fromJson('["3.11", "3.12"]') }}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore a reachable 3.11 CI leg

Because this workflow now only has a pull_request trigger, github.event_name is always pull_request here and the fromJson('["3.11", "3.12"]') branch is dead. I checked the referenced release/provider-drift workflows and they both pin Python 3.12, while pyproject.toml still advertises requires-python = ">=3.11" and a Python 3.11 classifier, so 3.11 regressions are no longer exercised anywhere before shipping.

Useful? React with 👍 / 👎.

steps:
- uses: actions/checkout@v6
- uses: actions/setup-python@v6
Expand Down