Skip to content

Add @SpringConversion negative test#68

Merged
scordio merged 1 commit intomainfrom
spring-conversion-negative-tests
Feb 8, 2026
Merged

Add @SpringConversion negative test#68
scordio merged 1 commit intomainfrom
spring-conversion-negative-tests

Conversation

@scordio
Copy link
Owner

@scordio scordio commented Feb 8, 2026

This adds a negative test for when spring-core is not in the classpath.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a regression/negative integration test to ensure @SpringConversion fails in a predictable way when spring-core is absent from the runtime classpath, using a custom classloader to simulate that environment.

Changes:

  • Added a negative integration test case that runs a parameterized test under a classloader that blocks org.springframework.core.*.
  • Extended the local JUnit Platform testkit helper to support selecting tests using a provided ClassLoader.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/test/java/io/github/scordio/tests/junit/converters/SpringConversionIntegrationTests.java Adds a new negative test and a custom URLClassLoader that filters out Spring Core classes.
src/test/java/io/github/scordio/tests/junit/converters/JupiterEngineTestKit.java Adds an overload to execute a test class via JUnit Platform using a specific ClassLoader.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@scordio scordio force-pushed the spring-conversion-negative-tests branch from af3ddf2 to 65c1f1d Compare February 8, 2026 10:21
@scordio scordio merged commit 465f358 into main Feb 8, 2026
31 checks passed
@scordio scordio deleted the spring-conversion-negative-tests branch February 8, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant