Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a regression/negative integration test to ensure @SpringConversion fails in a predictable way when spring-core is absent from the runtime classpath, using a custom classloader to simulate that environment.
Changes:
- Added a negative integration test case that runs a parameterized test under a classloader that blocks
org.springframework.core.*. - Extended the local JUnit Platform testkit helper to support selecting tests using a provided
ClassLoader.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/test/java/io/github/scordio/tests/junit/converters/SpringConversionIntegrationTests.java |
Adds a new negative test and a custom URLClassLoader that filters out Spring Core classes. |
src/test/java/io/github/scordio/tests/junit/converters/JupiterEngineTestKit.java |
Adds an overload to execute a test class via JUnit Platform using a specific ClassLoader. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/test/java/io/github/scordio/tests/junit/converters/SpringConversionIntegrationTests.java
Show resolved
Hide resolved
src/test/java/io/github/scordio/tests/junit/converters/SpringConversionIntegrationTests.java
Show resolved
Hide resolved
af3ddf2 to
65c1f1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a negative test for when
spring-coreis not in the classpath.