Sirl#1
Open
flowerfox-scitix wants to merge 5 commits into
Open
Conversation
Base: scitix/Megatron-LM core_v0.16.1 (55ac708) Patch: slime/docker/patch/v0.5.7/megatron.patch (17 files) Applied cleanly: 11/17 files Conflicts resolved: 6/17 files - transformer_engine.py: kept ours (core_v0.16.1 has quant_context) - distrib_optimizer.py: took theirs (skip step key) - moe_utils.py: kept ours (core_v0.16.1 native RouterReplay) - router.py: kept ours (native RouterReplay, no slime import needed) - gpt_layer_specs.py: kept ours (full MLA + non-MLA spec construction) - gpt_model.py: kept both padding_mask + mtp_kwargs params, kept ours for MTP label handling and loss computation Key: routing replay is now native in core_v0.16.1 via megatron.core.transformer.moe.router_replay.RouterReplay. No external slime/sirl imports needed for this feature. Co-Authored-By: Claude <noreply@anthropic.com>
Core v0.16.1 has native RouterReplay, but sirl's actor.py fills replay buffers via sirl.utils.routing_replay.RoutingReplay instances. This hook registers with sirl's adapter so both systems stay in sync. Co-Authored-By: Claude <noreply@anthropic.com>
…ay guard Co-Authored-By: Claude <noreply@anthropic.com>
TransformerConfig fields (normalization, apply_residual_connection_post_layernorm, post_self_attn_layernorm, post_mlp_layernorm) are auto-registered by ArgumentGroupFactory. Remove manual add_argument to avoid argparse conflict. Keep only args NOT in TransformerConfig: norm-epsilon, apply-layernorm-1p, use-gated-attention. Co-Authored-By: Claude <noreply@anthropic.com>
ArgumentGroupFactory(TransformerConfig) auto-registers: normalization, norm-epsilon, apply-layernorm-1p, apply-residual-connection-post-layernorm, post-self-attn-layernorm, post-mlp-layernorm. All removed from manual add_argument. Only --use-gated-attention remains (not in TransformerConfig). Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.