Skip to content

Paper: Avoiding Zero-Trade Policies in RL - #1255

Open
tsho wants to merge 8 commits into
scipy-conference:2026from
tsho:1st_draft_sho_tanaka
Open

tsho wants to merge 8 commits into
scipy-conference:2026from
tsho:1st_draft_sho_tanaka

Conversation

@tsho

@tsho tsho commented Jun 20, 2026

Copy link
Copy Markdown

No description provided.

@tsho
tsho marked this pull request as draft June 20, 2026 19:31
@github-actions

github-actions Bot commented Jun 20, 2026 •

Copy link
Copy Markdown

Curvenote Preview

Directory Preview Checks Updated (UTC)
papers/sho_tanaka 🔍 Inspect ✅ 34 checks passed (5 optional) Oct 9, 2026, 5:34 AM

@tsho tsho changed the title Paper: Avoiding Zero-Trade Policies in RL Paper: Avoiding Zero-Trade Policies in RL Jun 20, 2026
@rowanc1 rowanc1 added the draft This triggers Curvenote Preview actions label Jun 20, 2026
@cdlindsey cdlindsey self-assigned this Jul 3, 2026
@ameyxd

ameyxd commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Hi, I am the assigned reviewer for this paper. I will provide my feedback in the next few days. Happy to work with you on improving!

@tsho

tsho commented Aug 19, 2026

Copy link
Copy Markdown
Author

Hi @ameyxd,

Thank you so much!

Since I originally shared the paper in this PR, I updated the poster content while preparing the poster to reflect the latest version of the work by the SciPy Cofenrece July.

Would it be okay if I update the file with the latest version before you start your review?

I really appreciate your help and look forward to your feedback.

@ameyxd

ameyxd commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Yes that is okay with me. @cdlindsey - does that work?

@anwarkhan-ai

Copy link
Copy Markdown

I have reviewed this paper, I will drop my comments here.

@anwarkhan-ai anwarkhan-ai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tsho This is a good problem to solve, zero trade convergence is a practical problem.
Seems like draft is incomplete. there are TODOs, I can not check the quantitative table and figure. Can you please complete it. Provider the tables, atleast one figure, code links, also check the reward confidence ration calculations.
Also some bin entries are never cite. I will respond quickly if you need any inputs from me.

Comment thread papers/sho_tanaka/main.md Outdated
Comment thread papers/sho_tanaka/main.md Outdated
Comment thread papers/sho_tanaka/main.md Outdated
Comment thread papers/sho_tanaka/main.md Outdated
Comment thread papers/sho_tanaka/main.md Outdated
@tsho

tsho commented Aug 23, 2026

Copy link
Copy Markdown
Author

Hi @anwarkhan-ai,
Thank you for reviewing it. As I mentioned earlier, this version was created one month before the SciPy Conference. I will update the figures, tables, and numerical results to reflect the final poster I presented at the conference.

@tsho

tsho commented Aug 29, 2026

Copy link
Copy Markdown
Author

Hi @ameyxd and @anwarkhan-ai

Thank you for your patience. I have revised the manuscript to accurately reflect the poster presented at SciPy 2026 and addressed the review comments.

Could you please review the updated version?

@ameyxd
ameyxd marked this pull request as ready for review September 1, 2026 22:58

@ameyxd ameyxd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, good work, well-written and concise writing. Good job with the references and the formatting as well. I recommend approval after these minor recommended revisions.

Comment thread papers/sho_tanaka/main.md
Comment thread papers/sho_tanaka/main.md Outdated
Comment thread papers/sho_tanaka/main.md
Comment thread papers/sho_tanaka/main.md Outdated
Comment thread papers/sho_tanaka/main.md Outdated
Comment thread papers/sho_tanaka/main.md Outdated
Comment thread papers/sho_tanaka/main.md Outdated
Comment thread papers/sho_tanaka/main.md Outdated
Comment thread papers/sho_tanaka/main.md Outdated
Comment thread papers/sho_tanaka/main.md
@tsho

tsho commented Sep 6, 2026

Copy link
Copy Markdown
Author

@ameyxd Appreciate it! Following all comments, modified/added/moved context. Could you confirm my updates? Thank you.

@ameyxd

ameyxd commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Approved. Good work!

@anwarkhan-ai anwarkhan-ai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved Good Work.

@ameyxd

@tsho

tsho commented Sep 13, 2026

Copy link
Copy Markdown
Author

Thanks @anwarkhan-ai for approving this PR!

Hi @ameyxd Thanks for confirming in the comments! Could you also formally approve the PR? Your review still shows “Changes requested,” as indicated by the red icon below.

image

@ameyxd

ameyxd commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Approved. Thank you for your submission! Cheers.

@tsho

tsho commented Sep 15, 2026

Copy link
Copy Markdown
Author

Thanks a lot!

@tsho

tsho commented Oct 1, 2026

Copy link
Copy Markdown
Author

Hi @cdlindsey, @rowanc1,

Other reviewer approved this PR.
Is there any process for publishing this paper?

Thank you!
Sho

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@fwkoch fwkoch added approved This triggers Curvenote Submission action and removed draft This triggers Curvenote Preview actions labels Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved This triggers Curvenote Submission action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants