Repository navigation
Conversation
|
hello! i'm a reviewer for this paper (J.R. Barhydt) |
Paper: PR post-ERB
for more information, see https://pre-commit.ci
|
Curvenote Preview
|
for more information, see https://pre-commit.ci
Sinkhorn DoI (use arXiv since neurips is down?)
for more information, see https://pre-commit.ci
|
@jrbarhydt I see the DOI linter is failing a check, though I'm fairly sure that paper only has a HAL ID. See here. I've updated the other DoIs and added CRediT roles. |
not sure why CI is rejecting.
|
@scipy-conference/2026-proceedings Having a little trouble getting the checks to pass! Let me know how I can get that fixed up. |
|
My background is not as heavy in software dev-ops stuff. Mostly just code from scientists, etc. I'll take a look later today and see if I can find anything. |
rowanc1
left a comment
There was a problem hiding this comment.
Some advice on failing checks, you can mark the errors as resolved in the myst.yml.
Co-authored-by: Rachael Sexton <rtbs@nist.gov>
for more information, see https://pre-commit.ci
|
@rowanc1 I took care of the doi issues but the checks are still failing, looks like a Node 20 issue? Or maybe a CI permissions setting? |
|
It looks like a security change that GitHub did yesterday. @fwkoch can you look into this? The actions are failing for all of scipy at the moment. |
|
This has been fixed up, and looks to all be passing now!! |
Please go ahead and review the content; we don't expect you to debug the formatting/CI issues. |
|
Thanks for this submission; it's a really interesting problem space. I have a couple Written qualityOverall clear and well-organized, with good instincts for explaining jargon to Technical Content / VerifiabilityI ran the full install and all three notebooks locally. One environment note Novelty and ImpactThe paper reads a little ambiguous about which parts are new versus consolidating Open questionsNote Would love your take on these below - not blockers, just things that stood out.
None of this is blocking at this stage. I'm looking forward to iterating as the |
|
Thanks for the amazing points! I'm working on bumping the python version requirement now, but I'll address each point shortly (another paper deadline internally for me this week 😅 ) |
|
Ok, new patches of affinis and contingency have been published, which broaden the python version requirements (seems like poetry/uv were...quite conservative, by default). I don't see any inline comments on the review pane, did I miss them? |
|
@jrbarhydt I'll work on those technical content/novelty comments shortly. As for the "open questions":
|
|
Update on the sparsity/parallel features for FP, my branch has a working prototype that should be able to handle your use-case. rtbs-dev/affinis#4 |
fixing per @jrbarhydt review
|
@jrbarhydt As for your point about impact and novelty disambiguation, I'm pretty sure you've got the gist of it, but I can try to maybe add a blurb in the early sections describing what exactly is new? for |
|
@rtbs-dev I did write all that coming off of writing a Journal review, so I had novelty central on my mind. I genuinely do think the gist is covered pretty well. SciPy presentations usually give room for survey and stuff, so I think it's good. I'll definitely take a look at your blurb on parallelism. Very cool stuff, thanks for sharing. |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Paper submission accompanying poster