Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gagnon Tahiri - FINAL #1031

Merged
merged 144 commits into from
Oct 29, 2024
Merged

Conversation

JustGag
Copy link
Contributor

@JustGag JustGag commented Oct 22, 2024

If you are creating this PR in order to submit a draft of your paper, please name your PR with Paper: <title>. An editor will then add a paper label and GitHub Actions will be run to check and build your paper.

See the project readme for more information.

Editor:

Reviewers:

Correct Water mass order
Adjustment F4 and F5
Text metrics adjustment
Fig2 adjustment
Corrections
Corrections
Adjustment
Removing key word
Adjustment
Corrections abstract
Correction title
Adjustment
Adjustment
Corrections Table 1
Corrections
Correction
Correction
Adjustment preprocessing
@JustGag
Copy link
Contributor Author

JustGag commented Oct 22, 2024

@rowanc1 @cbcunc Once again, we're sorry for the delay and, as we promised, we've pushed through the final paper version and won't be touching it again. We'd be interested to get the link to the latest version of our paper, to see if the latest changes to the text and figures have been followed correctly. Thank you so much. Sincerely,

@rowanc1 rowanc1 merged commit 5667075 into scipy-conference:2024 Oct 29, 2024
6 of 12 checks passed
rowanc1 added a commit that referenced this pull request Oct 29, 2024
@rowanc1
Copy link
Contributor

rowanc1 commented Oct 29, 2024

We have merged your changes in, I have made a few updates:

f792cb1

You were missing two references and I moved to autoref and fixed subscript in math mode (textsubscript is not allowed).

I will get the final version up very soon.

@JustGag
Copy link
Contributor Author

JustGag commented Oct 29, 2024

We have merged your changes in, I have made a few updates:

f792cb1

You were missing two references and I moved to autoref and fixed subscript in math mode (textsubscript is not allowed).

I will get the final version up very soon.

@rowanc1 Thank you very much for your adjustments to our paper. We look forward to the final version. Sincerely,

@rowanc1
Copy link
Contributor

rowanc1 commented Oct 29, 2024

Hi @JustGag the paper is now live, with the PDF at:

https://proceedings.scipy.org/articles/NVYF1037

@JustGag
Copy link
Contributor Author

JustGag commented Oct 29, 2024

Hi @JustGag the paper is now live, with the PDF at:

https://proceedings.scipy.org/articles/NVYF1037

Hi @rowanc1 Thank you for converting our paper to PDF.

We wanted to know, since we hadn't anticipated the PDF layout, if we had to make minor adjustments related to sources and the size of certain figures, would it be possible to apply them?

Sincerely,

@rowanc1
Copy link
Contributor

rowanc1 commented Oct 29, 2024

The PDF generation is not very flexible, is there a figure you have in mind that needs attention?

@JustGag
Copy link
Contributor Author

JustGag commented Oct 29, 2024

The PDF generation is not very flexible, is there a figure you have in mind that needs attention?

After comparing the paper on the SciPy site and the PDF, we can see that this may be due to the conversion to PDF. Would it be possible to send them back to you with the excess margins removed from the figure images?

As for the sources, we'd like to reverse the order in which they appear throughout the aPhyloGeo section, from \citep{li2024host, li2023aphylogeo, koshkarov_phylogeography_2022} to \citep{koshkarov_phylogeography_2022, li2023aphylogeo, li2024host}. There's also one in the Robinson-Foulds distance section: \citep{li2024comparison, tahiri2018new} to \citep{tahiri2018new, li2024comparison}.

P-s: At this point, do these adjustments have to come from our side or yours?

Thank you for your understanding.

Sincerely,

@rowanc1
Copy link
Contributor

rowanc1 commented Oct 30, 2024

Feel free to open another pull request to change these small things. Please ensure that it is rebasing on top of the 2024 branch!

@JustGag
Copy link
Contributor Author

JustGag commented Nov 14, 2024

Hi @rowanc1, we've made the necessary changes and opened a new pull request for our paper.

Thank you very much.

Sincerely,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants