Skip to content

Fix uninitialized variable warnings and typo in variable name #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix uninitialized variable warnings and typo in variable name #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
809455e
Update set_commitment_gadget.tcc
zeevick10 Jul 6, 2025
d366145
Update sparse_vector.tcc
zeevick10 Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libsnark/common/data_structures/sparse_vector.tcc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ std::pair<T, sparse_vector<T> > sparse_vector<T>::accumulate(const typename std:

const size_t range_len = it_end - it_begin;
bool in_block = false;
size_t first_pos = -1, last_pos = -1; // g++ -flto emits unitialized warning, even though in_block guards for such cases.
size_t first_pos = -1, last_pos = -1; // g++ -flto emits uninitialized warning, even though in_block guards for such cases.

for (size_t i = 0; i < indices.size(); ++i)
{
Expand Down
2 changes: 1 addition & 1 deletion libsnark/gadgetlib1/gadgets/set_commitment/set_commitment_gadget.tcc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ void test_set_commitment_gadget()
element_bits.allocate(pb, value_size, "element_bits");
set_commitment_variable<FieldT, HashT> root_digest(pb, digest_len, "root_digest");

pb_variable<FieldT> check_succesful;
pb_variable<FieldT> check_successful;
check_succesful.allocate(pb, "check_succesful");

set_membership_proof_variable<FieldT, HashT> proof(pb, max_set_size, "proof");
Expand Down