Skip to content

Fix max matrix size in SCIPexprComputeQuadraticCurvature #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaximSmolskiy wants to merge 1 commit into from
Closed

Fix max matrix size in SCIPexprComputeQuadraticCurvature #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/scip/expr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3681,10 +3681,10 @@ SCIP_RETCODE SCIPexprComputeQuadraticCurvature(
n = quaddata->nquadexprs;

/* do not check curvature if nn will be too large
* we want nn * sizeof(real) to fit into an unsigned int, so n must be <= sqrt(unit_max/sizeof(real))
* sqrt(2*214748364/8) = 7327.1475350234
* we want nn * sizeof(real) to fit into an unsigned int, so n must be <= sqrt(uint_max/sizeof(real))
* sqrt(4294967295/8) = 23170.47500322339
*/
if( n > 7000 )
if( n > 23000 )
{
SCIPmessageFPrintVerbInfo(messagehdlr, set->disp_verblevel, SCIP_VERBLEVEL_FULL, NULL,
"number of quadratic variables is too large (%d) to check the curvature\n", n);
Expand Down
2 changes: 1 addition & 1 deletion src/scip/nlhdlr_soc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2148,7 +2148,7 @@ SCIP_RETCODE detectSocQuadraticComplex(
}

/* check that nvars*nvars doesn't get too large, see also SCIPcomputeExprQuadraticCurvature() */
if( nvars > 7000 )
if( nvars > 23000 )
{
SCIPverbMessage(scip, SCIP_VERBLEVEL_FULL, NULL, "nlhdlr_soc - number of quadratic variables is too large (%d) to check the curvature\n", nvars);
SCIPfreeBufferArray(scip, &occurringexprs);
Expand Down