Skip to content

Update INSTALL.md #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 19, 2025
Merged

Update INSTALL.md #974

merged 4 commits into from
Apr 19, 2025

Conversation

Joao-Dionisio
Copy link
Member

No description provided.

@DominikKamp
Copy link
Contributor

Could this also be added as note at https://pyscipopt.readthedocs.io/en/latest/install.html#id2?

@Joao-Dionisio
Copy link
Member Author

Joao-Dionisio commented Apr 17, 2025 •
edited
Loading

@DominikKamp done. I've always been a staunch defender of GitHub over GitLab, but the lack of threads is very annoying.

EDIT: We need to update our workflows to use a newer ubuntu.

@Joao-Dionisio
Copy link
Member Author

@DominikKamp , can you approve please?

DominikKamp
DominikKamp reviewed Apr 19, 2025
View reviewed changes
@DominikKamp
Copy link
Contributor

I've always been a staunch defender of GitHub over GitLab, but the lack of threads is very annoying.

GitHub makes actual reviews unnecessarily difficult.

DominikKamp
DominikKamp approved these changes Apr 19, 2025
View reviewed changes
Copy link
Contributor

@DominikKamp DominikKamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, this is fine, thank you!

@Joao-Dionisio
Copy link
Member Author

thanks for the review!

@Joao-Dionisio Joao-Dionisio merged commit 648bdfe into master Apr 19, 2025
1 check passed
@Joao-Dionisio Joao-Dionisio deleted the dominik-note branch April 19, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominikKamp DominikKamp DominikKamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joao-Dionisio @DominikKamp