Conversation
|
Hello @SimonErm! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-06-16 17:16:28 UTC |
|
This pull request introduces 5 alerts when merging 948da4a into b861b3a - view on LGTM.com new alerts:
|
|
This pull request introduces 4 alerts when merging bef0487 into b861b3a - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
==========================================
- Coverage 98.65% 96.55% -2.10%
==========================================
Files 82 82
Lines 4907 5140 +233
==========================================
+ Hits 4841 4963 +122
- Misses 66 177 +111
Continue to review full report at Codecov.
|
|
This pull request introduces 5 alerts when merging 3361578 into 2a0376e - view on LGTM.com new alerts:
|
|
@SimonErm is this PR still in progress? |
|
The current state of the implementation is working for me, but i think it's far from being ready to be merged into this package. |
|
@SimonErm Thanks for the reply. |
|
I really want this. |
|
Hi all, I was wondering if someone is working on this or similar implementation of MLSMOTE. I am interested in trying this algorithm. I might have some time to try to implement it. Would anyone be able to review it? |
Contributions are always more than welcome |
Reference Issue
The motivation for this PR is mentioned in #340
What does this implement/fix? Explain your changes.
The PR implements MLSMOTE like discribed in
Charte, F. & Rivera Rivas, Antonio & Del Jesus, María José & Herrera, Francisco. (2015). MLSMOTE: Approaching imbalanced multilabel learning through synthetic instance generation. Knowledge-Based Systems. -. 10.1016/j.knosys.2015.07.019.Any other comments?
This implementation is missing lots of validation, sparse matrix support, pandas support and has a bad perfromance. It's alread open because of @chkoar s suggestion in the referenced Issue(#340 ).
Since i am not an experienced python developer i am thankful for every suggestion for improvement