Skip to content

detx: don't catch exceptions and retry with wider type #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

detx: don't catch exceptions and retry with wider type #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions src/detx.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,11 @@ Here `T` can be any kind of integer, rational, `Mod`, or `GF2`.
I hope to expand this to `Polynomial`s.
"""
function detx(A::AbstractMatrix{T}) where {T<:IntegerX}
# @info "Using IntegerX detx{$T}"
try
return T(det(A // 1))
catch
A = big.(A)
return detx(A)
end
det(A // true)
end

function detx(A::AbstractMatrix{T}) where {T<:RationalX}
# @info "Using RationalX detx{$T}"
try
return det(A)
catch
return det(big.(A))
end
det(A)
end

function detx(A::AbstractMatrix{T}) where {T}
Expand Down