Skip to content

Commit

Permalink
In QUIC netlog, print string literal for error code in STOP_SENDING.
Browse files Browse the repository at this point in the history
https://source.chromium.org/chromium/chromium/src/+/master:third_party/catapult/netlog_viewer/netlog_viewer/log_view_painter.js;l=411?q=quic_rst_stream_error&ss=chromium%2Fchromium%2Fsrc does the tostring part.

Change-Id: I0d7dd8af1c0d13f655202f732fd512862550f0f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2699008
Auto-Submit: Renjie Tang <renjietang@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#854573}
  • Loading branch information
Renjie Tang authored and Chromium LUCI CQ committed Feb 17, 2021
1 parent 14d5f16 commit fb4b2a0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions net/log/net_log_event_type_list.h
Original file line number Diff line number Diff line change
Expand Up @@ -1943,19 +1943,19 @@ EVENT_TYPE(QUIC_SESSION_STOP_WAITING_FRAME_RECEIVED)
// }
EVENT_TYPE(QUIC_SESSION_STOP_WAITING_FRAME_SENT)

// Session recevied a RST_STREAM frame.
// Session received a RST_STREAM frame.
// {
// "offset": <Offset in the byte stream which triggered the reset>,
// "quic_rst_stream_error": <quic::QuicRstStreamErrorCode in the frame>,
// "details": <Human readable description>,
// "stream_id": <The stream id which this frame refers to>,
// }
EVENT_TYPE(QUIC_SESSION_RST_STREAM_FRAME_RECEIVED)

// Session sent a RST_STREAM frame.
// {
// "offset": <Offset in the byte stream which triggered the reset>,
// "quic_rst_stream_error": <quic::QuicRstStreamErrorCode in the frame>,
// "details": <Human readable description>,
// "stream_id": <The stream id which this frame refers to>,
// }
EVENT_TYPE(QUIC_SESSION_RST_STREAM_FRAME_SENT)

Expand Down Expand Up @@ -2109,14 +2109,14 @@ EVENT_TYPE(QUIC_SESSION_CRYPTO_FRAME_RECEIVED)
// Session sent a STOP_SENDING frame.
// {
// "stream_id": <The stream id>,
// "application_error_code": <The application error code>
// "rsr_stream_error_code": <quic::QuicRstStreamErrorCode in the frame>
// }
EVENT_TYPE(QUIC_SESSION_STOP_SENDING_FRAME_SENT)

// Session received a STOP_SENDING frame.
// {
// "stream_id": <The stream id>,
// "application_error_code": <The application error code>
// "rsr_stream_error_code": <Tquic::QuicRstStreamErrorCode in the frame>
// }
EVENT_TYPE(QUIC_SESSION_STOP_SENDING_FRAME_RECEIVED)

Expand Down
2 changes: 1 addition & 1 deletion net/quic/quic_event_logger.cc
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ base::Value NetLogQuicStopSendingFrameParams(
const quic::QuicStopSendingFrame* frame) {
base::Value dict(base::Value::Type::DICTIONARY);
dict.SetIntKey("stream_id", frame->stream_id);
dict.SetIntKey("error_code", frame->error_code);
dict.SetIntKey("quic_rst_stream_error", frame->error_code);
return dict;
}

Expand Down

0 comments on commit fb4b2a0

Please sign in to comment.