Skip to content

Commit

Permalink
[code coverage] Turn on experiment for linux-coverage-rel to 10%
Browse files Browse the repository at this point in the history
The linux-coverage-rel bot is relatively stable now, only 1 build
failed out of the last 15 builds manually triggered by developers.

A dedicated pool of 7 bots were created for linux-coverage-rel and
80 VMs were added to the main testing fleet, so enough capacity is
ensured for 10% experiment for linux-coverage-rel.

Following are the CLs that added capacity for this experiment:
https://chrome-internal-review.googlesource.com/c/infradata/config/+/874989
https://chrome-internal-review.googlesource.com/c/infradata/config/+/867204

Bug: 930364
Change-Id: I4614e31f43217940fc841093fe98fbfb620f8cbb
Reviewed-on: https://chromium-review.googlesource.com/c/1474549
Reviewed-by: Stephen Martinis <[email protected]>
Reviewed-by: John Budorick <[email protected]>
Commit-Queue: Yuke Liao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#633991}
  • Loading branch information
Yuke Liao authored and Commit Bot committed Feb 21, 2019
1 parent cf73666 commit 344abca
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
4 changes: 4 additions & 0 deletions docs/infra/cq_builders.md
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,10 @@ as required builders.

* Experimental percentage: 10

* [linux-coverage-rel](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-coverage-rel) ([`commit-queue.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:commit-queue.cfg+chromium/try/linux-coverage-rel)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+linux-coverage-rel))

* Experimental percentage: 10

* [linux-dcheck-off-rel](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-dcheck-off-rel) ([`commit-queue.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:commit-queue.cfg+chromium/try/linux-dcheck-off-rel)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+linux-dcheck-off-rel))

https://crbug.com/833482
Expand Down
12 changes: 8 additions & 4 deletions infra/config/commit-queue.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
# documentation of this file format.
#
# This file is also used to auto generate //docs/infra/cq_builders.md. If you
# change this file, run //infra/config/branch/cq_cfg_presubmit.py, which will
# generate that file. That script also requires that the builders in this file
# remain sorted. The script is invoked via presubmit, and will complain if this
# file is change but the documentation isn't.
# change this file, run //infra/config/cq_cfg_presubmit.py, which will generate
# that file. That script also requires that the builders in this file remain
# sorted. The script is invoked via presubmit, and will complain if this file is
# changed but the documentation isn't.
#
# The auto generated file copies comments made to builders in this file. If you
# comment on the line directly above a builder, that comment will get copied to
Expand Down Expand Up @@ -288,6 +288,10 @@ config_groups {
name: "chromium/try/ios-simulator-xcode-clang"
experiment_percentage: 10
}
builders {
name: "chromium/try/linux-coverage-rel"
experiment_percentage: 10
}
# https://crbug.com/833482
builders {
name: "chromium/try/linux-dcheck-off-rel"
Expand Down

0 comments on commit 344abca

Please sign in to comment.