Skip to content

scx_lavd: Fix pick_most_loaded_dsq() when --per-cpu-dsq is given. #3070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

scx_lavd: Fix pick_most_loaded_dsq() when --per-cpu-dsq is given. #3070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions scheds/rust/scx_lavd/src/bpf/balance.bpf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ static bool consume_dsq(struct cpdom_ctx *cpdomc, u64 dsq_id)
u64 __attribute__((noinline)) pick_most_loaded_dsq(struct cpdom_ctx *cpdomc)
{
u64 pick_dsq_id = -ENOENT;
s32 highest_queued = 0;
s32 highest_queued = -1;

if (!cpdomc) {
scx_bpf_error("Invalid cpdom context");
Expand All @@ -214,7 +214,7 @@ u64 __attribute__((noinline)) pick_most_loaded_dsq(struct cpdom_ctx *cpdomc)
bpf_for(i, 0, LAVD_CPU_ID_MAX/64) {
u64 cpumask = cpdomc->__cpumask[i];
bpf_for(k, 0, 64) {
u64 queued;
s32 queued;
j = cpumask_next_set_bit(&cpumask);
if (j < 0)
break;
Expand All @@ -229,15 +229,8 @@ u64 __attribute__((noinline)) pick_most_loaded_dsq(struct cpdom_ctx *cpdomc)
}
}

if (pick_cpu != -ENOENT) {
struct cpu_ctx *pick_cpuc = get_cpu_ctx_id(pick_cpu);
if (!pick_cpuc) {
scx_bpf_error("Failed to lookup cpu_ctx: %d", pick_cpu);
return -ENOENT;
}

pick_dsq_id = cpdom_to_dsq(pick_cpuc->cpdom_id);
}
if (pick_cpu != -ENOENT)
pick_dsq_id = cpu_to_dsq(pick_cpu);
}

return pick_dsq_id;
Expand Down