-
Notifications
You must be signed in to change notification settings - Fork 2
SPRXCLT-21: Add head() method to return full HTTP headers #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPRXCLT-21: Add head() method to return full HTTP headers #311
Conversation
fredmnl
commented
Oct 29, 2025
- Add new head() method that returns complete headers object
- Keeps existing getHEAD() for backward compatibility (returns only x-scal-usermd)
Hello fredmnl,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
lib/sproxyd.js
Outdated
| * where usermd is the x-scal-usermd header value (base64 string) | ||
| * @returns {undefined} | ||
| */ | ||
| getHEAD(key, reqUids, callback) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| getHEAD(key, reqUids, callback) { | |
| getUsermd(key, reqUids, callback) { |
Change the API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was wondering whether I should simply change the API and break the clients (they'll just have to update their code), or mark it as deprecated first.
@borisfaure @jonathan-gramain What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though the lib is public, the only known users are Scality. Updating the caller at the same time the lib is bumped looks easy and solid enough to take the opportunity for a more readable API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep sounds good to me 👍
I changed it to getUserMetadata
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
- Add new head() method that returns complete headers object - Keeps existing getHEAD() for backward compatibility (returns only x-scal-usermd)
88d49a6 to
9b7ff3b
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
/approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue SPRXCLT-21. Goodbye fredmnl. The following options are set: approve |