LOGC-40: Migrate to workbench ClickHouse for tests #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update services to the latest versions - Add clickhouse.image - Enable access_logging feature
Workbench uses workbench_cluster.
dvasilas
changed the title
BourgoisMickael
approved these changes
Jan 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 73.19% 73.19%
=======================================
Files 21 21
Lines 1608 1608
=======================================
Hits 1177 1177
Misses 346 346
Partials 85 85
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
tcarmet
reviewed
Jan 7, 2026
dvasilas
force-pushed
the
improvement/LOGC-40
branch
from
30ce72a to
8e432b9
Compare
tcarmet
approved these changes
Jan 9, 2026
tcarmet
reviewed
Jan 9, 2026
.github/workflows/tests.yaml
Outdated
| version: v2.1.6 | ||
|
|
||
| - name: Start Workbench | ||
| uses: scality/workbench@improvement/WKBCH-13-clickhouse |
Contributor
There was a problem hiding this comment.
Once you'll merge your changes in workbench, just directly make a release, there's no "action" for it and it will directly trigger the necessary workflow.
This prevents "permission denied" errors when go test tries to scan workbench-created directories.
dvasilas
force-pushed
the
improvement/LOGC-40
branch
2 times, most recently
from
c5a9b8d to
c9febb5
Compare
- Run linter before workbench to avoid permission errors on env/ - Wait for workbench setup container and both ClickHouse shards (port 9002)
dvasilas
force-pushed
the
improvement/LOGC-40
branch
from
c9febb5 to
c2733cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates log-courier from using a local docker-compose to deploy ClickHouse to using workbench
Best reviewed commit-by-commit.