(wip) functional tests for sse KMS Migration #5793
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BourgoisMickael
force-pushed
the
improvement/CLDSRV-636-kms-provider-tests
branch
from
1a9a476 to
7412709
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds functional tests to verify the SSE KMS migration, including bucket cleanup procedures and updated CI workflow steps to run tests before and after migration.
- Added a cleanup script to remove test buckets post-migration tests.
- Introduced a new matrix job in the CI workflow to execute tests under different configurations, with corresponding environment variable adjustments.
- Updated the Docker Compose configuration to mount dynamic configuration files and local data directories required for the tests.
Reviewed Changes
Copilot reviewed 6 out of 10 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/functional/kms-sse-migration/cleanup.js | Adds a cleanup script for emptying and deleting test buckets. |
| .github/workflows/tests.yaml | Introduces a new matrix job for SSE KMS migration tests and updates test steps accordingly. |
| .github/docker/docker-compose.yaml | Adds volume mounts for dynamic config and local data required during testing. |
Files not reviewed (4)
- package.json: Language not supported
- tests/functional/kms-sse-migration/config.before.json: Language not supported
- tests/functional/kms-sse-migration/config.sseMigration.hideArn.json: Language not supported
- tests/functional/kms-sse-migration/config.sseMigration.showArn.json: Language not supported
BourgoisMickael
force-pushed
the
improvement/CLDSRV-636-kms-provider-tests
branch
19 times, most recently
from
42ae679 to
03020da
Compare
BourgoisMickael
changed the base branch from
improvement/CLDSRV-636-kms-provider
to
improvement/CLDSRV-636-kms-provider-outscale-config
BourgoisMickael
force-pushed
the
improvement/CLDSRV-636-kms-provider-tests
branch
from
03020da to
14720c2
Compare
BourgoisMickael
force-pushed
the
improvement/CLDSRV-636-kms-provider-outscale-config
branch
from
e7ed145 to
3ec9594
Compare
BourgoisMickael
force-pushed
the
improvement/CLDSRV-636-kms-provider-tests
branch
4 times, most recently
from
8ef4580 to
0f428f2
Compare
BourgoisMickael
force-pushed
the
improvement/CLDSRV-636-kms-provider-outscale-config
branch
from
3ec9594 to
a3cb2d6
Compare
Need a script to run before version then upgrade version and rerun I'll try to clean this test
BourgoisMickael
force-pushed
the
improvement/CLDSRV-636-kms-provider-tests
branch
from
81e04ff to
9e168fb
Compare
Base automatically changed from
improvement/CLDSRV-636-kms-provider-outscale-config
to
hotfix/7.70.21.outscale
May 14, 2025 22:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: run previous version in CI to setup tests and then run latest version.
I'll try to make tests cleaner