Skip to content

chore(org): regenerate proto types with logo_url field#160

Closed
srinivaskarre-sk wants to merge 2 commits into
mainfrom
b_d_org_logo
Closed

chore(org): regenerate proto types with logo_url field#160
srinivaskarre-sk wants to merge 2 commits into
mainfrom
b_d_org_logo

Conversation

@srinivaskarre-sk
Copy link
Copy Markdown
Contributor

@srinivaskarre-sk srinivaskarre-sk commented May 17, 2026

Summary

  • Regenerated proto types with logo_url field on CreateOrganization, Organization, UpdateOrganization, and auth Organization
  • No wrapper changes needed — callers pass proto types directly and can set logo_url on CreateOrganization(logo_url='https://...')

Test plan

  • create_organization(CreateOrganization(display_name='Acme', logo_url='https://...')) returns org with logo_url set

Summary by CodeRabbit

  • New Features

    • Added logo URL support for organizations.
    • Added WebAuthn, OAuth M2M, and Trello OAuth1 connection types.
  • Removed Features

    • Removed Google DWD connector support.
    • Removed metadata field from provider configurations.
    • Removed timeout unit fields from session policy settings.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 17, 2026

Warning

Rate limit exceeded

@srinivaskarre-sk has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 50 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5564a028-b51a-444e-a77f-03cc7a5cbc36

📥 Commits

Reviewing files that changed from the base of the PR and between 18e8cd7 and 842c7ee.

📒 Files selected for processing (1)
  • tests/test_organization.py

Walkthrough

This PR regenerates protobuf-generated Python stubs across five modules to align with updated proto schemas. Changes include adding logo_url to organization messages, removing Google DWD connector and connection type support, adding new connection types (WEBAUTHN, OAUTH_M2M, TRELLO_OAUTH1), simplifying session policy settings by removing timeout unit enums, and removing metadata map fields from provider messages.

Changes

Protobuf Schema Updates

Layer / File(s) Summary
Auth module: Organization logo_url field
scalekit/v1/auth/auth_pb2.py, scalekit/v1/auth/auth_pb2.pyi
Serialized descriptor and field options updated; _INTENT and _AUTHSTATE offset indices recalculated. Organization stub extended with logo_url: str field in __slots__, added LOGO_URL_FIELD_NUMBER constant, declared attribute, and constructor parameter.
Connected accounts: Remove Google DWD support
scalekit/v1/connected_accounts/connected_accounts_pb2.py, scalekit/v1/connected_accounts/connected_accounts_pb2.pyi
Serialized descriptor updated; _GOOGLEDWDAUTH per-field serialized options removed; descriptor offset indices for _CONNECTORSTATUS, _CONNECTORTYPE, AuthorizationDetails, and service spans recalculated. ConnectorType enum loses GOOGLE_DWD value; AuthorizationDetails removes google_dwd field and GoogleDWDAuth message type is removed from stubs.
Connections: Remove Google DWD, add WEBAUTHN/OAUTH_M2M/TRELLO_OAUTH1
scalekit/v1/connections/connections_pb2.pyi
ConnectionType enum mapping updated to replace GOOGLE_DWD with WEBAUTHN, OAUTH_M2M, TRELLO_OAUTH1. Connection and UpdateConnection message stubs drop google_dwd_config from __slots__, field-number constants, and constructor signatures. GoogleDWDConfig message class removed entirely.
Organizations: Add logo_url fields and simplify session policy
scalekit/v1/organizations/organizations_pb2.pyi
CreateOrganization, Organization, and UpdateOrganization each extended with logo_url: str field in __slots__, LOGO_URL_FIELD_NUMBER constant, attribute, and constructor parameter. ApplicationSessionPolicySettings narrows __slots__ and constructor by removing absolute_session_timeout_unit and idle_session_timeout_unit parameters.
Providers: Remove metadata field from Provider and custom provider messages
scalekit/v1/providers/providers_pb2.py, scalekit/v1/providers/providers_pb2.pyi
Serialized descriptor updated; CreateCustomProvider and UpdateCustomProvider metadata entry/field descriptor initialization removed; all descriptor offset indices recalculated. Provider, CreateCustomProvider, and UpdateCustomProvider stubs drop metadata map from __slots__, remove METADATA_FIELD_NUMBER constants, remove metadata constructor parameter, and remove nested MetadataEntry classes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • scalekit-inc/scalekit-sdk-python#152: Changes to ApplicationSessionPolicySettings in this PR (removal of absolute_session_timeout_unit and idle_session_timeout_unit) directly impact the session policy method signature and logic added in that PR.
  • scalekit-inc/scalekit-sdk-python#148: Both PRs regenerate the ConnectedAccountService descriptor content and serialization spans in scalekit/v1/connected_accounts/connected_accounts_pb2.py at the protobuf service level.
  • scalekit-inc/scalekit-sdk-python#159: Removal of metadata fields from Provider, CreateCustomProvider, and UpdateCustomProvider in this PR directly impacts the custom provider CRUD operations introduced in that PR.

Suggested reviewers

  • Avinash-Kamath

Poem

🐰 The schemas shift, the stubs rebuild,
Google DWD fades, new types instilled,
Logo URLs shine, metadata gone,
Proto wheels turn—the march goes on!
Protobuf dance, perfectly spun,
Scalekit's refactor: another one done!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary change: proto type regeneration to add logo_url field to organization messages.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch b_d_org_logo

Comment @coderabbitai help to get the list of available commands and usage tips.

Tests for create with logo_url, update to set/clear, and verification
that logo_url is preserved after update_organization_settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant