Fix getting a free socket on macos #420
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bell-db fyi |
thesamet
reviewed
Mar 25, 2025
| * which does not conflict with existing 'localhost' sockets, | ||
| * resulting in a conflict later on in MacPluginFrontend | ||
| */ | ||
| def getFreeSocket(): ServerSocket = { |
There was a problem hiding this comment.
Any reason not to do this on all platforms?
There was a problem hiding this comment.
The only reason is me not being able to test it on Windows.
There was a problem hiding this comment.
We have a CI job that will test it on Windows, Mac and Linux. Can you also run scalafmt so the tests will pass?
There was a problem hiding this comment.
Sure, I've updated the pull request
There was a problem hiding this comment.
@thesamet, could you approve the awaiting workflow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a new fix for a free socket on mac problem, without restry.
Turns out mac allows a socket on ANY host (. in netstat) to bind even though a socket with localhost and a same port is present in LISTENING state. This is different from linux, where such an attempt would fail with a java.net.BindException.
A way to fix this is by simply passing a localhost (or rather 127.0.0.1, to match MacPluginFrontend) to ServerSocket constructor.
I've test it on my project, and got no failures on 5 rebuilds (it used to be 2 failed bazel targets per rebuild on protoc-bridge:0.9.8).