bugfix: Fix issue with empty name throwing exceptions#25752
Merged
zielinsky merged 1 commit intoscala:mainfrom Apr 10, 2026
Merged
bugfix: Fix issue with empty name throwing exceptions#25752zielinsky merged 1 commit intoscala:mainfrom
zielinsky merged 1 commit intoscala:mainfrom
Conversation
som-snytt
reviewed
Apr 9, 2026
| val nameString = name.toString | ||
| if nameString.isEmpty then false | ||
| else if completionMode.is(Mode.Member) then CompletionFuzzy.matchesSubCharacters(completionPos.query, name.toString) | ||
| else CompletionFuzzy.matches(completionPos.query, name.toString) |
Contributor
There was a problem hiding this comment.
did you intend nameString again? edit: in both places.
My style would be nameString.nonEmpty && { the rest } for some reason to be discussed at happy hour.
zielinsky
reviewed
Apr 10, 2026
presentation-compiler/src/main/dotty/tools/pc/completions/Completions.scala
Outdated
Show resolved
Hide resolved
I could reproduce it in the presentation compiler module, it would sometimes break when rapidly writing code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could reproduce it in the presentation compiler module, it would sometimes break when rapidly writing code.
How much have you relied on LLM-based tools in this contribution?
None
How was the solution tested?
Manually working on the compiler.
Additional notes