Skip to content

Optimize the standard library in bootstrapped compilation #25689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SolalPirelli wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Optimize the standard library in bootstrapped compilation #25689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/test/scala/collection/immutable/RangeProps.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ abstract class RangeProps(kind: String) extends Properties("Range "+kind) {
def compare(x: Int, y: Int): Int = ???
}

val rSum = r.sum(mynum)
val rSum = r.sum(using mynum)
Copy link
Copy Markdown
Contributor Author

@SolalPirelli SolalPirelli Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed this as a warning in compilation output, I must've missed it when porting the scalacheck stuff

val expected = mynum.toInt(r.sum)

(rSum == expected) :| str(r)
Expand Down
2 changes: 1 addition & 1 deletion project/Build.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1206,7 +1206,7 @@ object Build {
Compile / unmanagedSourceDirectories += baseDirectory.value / "src-bootstrapped",
Compile / unmanagedResourceDirectories := Seq(baseDirectory.value / "resources"),
Compile / compile / scalacOptions ++= Seq(
/* TODO: enable for Scala 3.9: "-opt", "-opt-inline:**,!java.**", */
"-opt", "-opt-inline:**,!java.**",
Copy link
Copy Markdown
Contributor

@tgodzik tgodzik Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might still need 3.9, @WojciechMazur or we just do 3.8.4-RC2 with the backported regression?

// Needed so that the library sources are visible when `dotty.tools.dotc.core.Definitions#init` is called
"-sourcepath", (Compile / sourceDirectories).value.map(_.getCanonicalPath).distinct.mkString(File.pathSeparator),
),
Expand Down
Loading