Add missing apply constructors for Refined and TypeProjection TypeTrees
#23837
+77
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchyb
force-pushed
the
add-missing-quotes-constructors
branch
2 times, most recently
from
b0b43be to
8f730e1
Compare
jchyb
added
the
needs-minor-release
Member
|
@jchyb Can you please rebase and fix the conflicts. Thanks. |
jchyb
force-pushed
the
add-missing-quotes-constructors
branch
from
8f730e1 to
feb1a8c
Compare
Gedochao
added
the
backport:nominated
Contributor
|
@WojciechMazur tagging you to keep track of this, I'm thinking we should get it into 3.8.0-RC1 |
Contributor
|
@jchyb would you be able to rebase once again...? We've let it hang for quite a bit, I know. |
jchyb
force-pushed
the
add-missing-quotes-constructors
branch
from
feb1a8c to
d18ec54
Compare
Contributor
Author
|
Apologies, I also forgot about this. If backporting this this late would be troubling then in my opinion this is something that could potentially wait for 3.10 (everything added here in this PR could previously be achieved in other ways, the changes here are for convenience and completeness) |
Contributor
|
@hamzaremmal bump for the review |
hamzaremmal
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11755
TypeBind is omitted, for reasons mentioned in #23836
I should mention that neither of these constructors is critical (we can just convert the
TypeReprcounterparts toTypeTrees), but I guess they are nice to have.