Repository navigation
Fix irrefutability checking in for with untupling - #23273
Merged
Merged
Conversation
Before this PR, the two for comprehensions in the added test case behaved differently: ```scala -- Error: tests/neg/irrefutable-genfrom.scala:5:10 ----------------------------- 5 | (i, Some(_)) <- List.empty[Int] zip List.empty[Option[String]] // error | ^^^^^^^ |pattern's type Some[String] is more specialized than the right hand side expression's type Option[String] | |If the narrowing is intentional, this can be communicated by adding the `case` keyword before the full pattern, |which will result in a filtering for expression (using `withFilter`). |This patch can be rewritten automatically under -rewrite -source 3.2-migration. -- Warning: tests/neg/irrefutable-genfrom.scala:11:6 --------------------------- 11 | (i, Some(_)) <- List.empty[Int] lazyZip List.empty[Option[String]] // error | ^ |pattern's type Some[String] is more specialized than the right hand side expression's type Option[String] | |If the narrowing is intentional, this can be communicated by adding `: @unchecked` after the expression, |which may result in a MatchError at runtime. |This patch can be rewritten automatically under -rewrite -source 3.2-migration. ``` The second one was incorrect: just like the first one, we should use the `case` keyword to make the pattern partial since we're in a for comprehension, but this information was lost when calling `makeCaseLambda` in `typedFunctionValue`. To fix this, we need to retrieve the attachment in the scrutinee (it was added there by `makeSelector` called from `makeCaseLambda` called from `makeLambda` called from `makeFor` in `Desugar.scala`).
KacperFKorban
approved these changes
Jun 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, the two for comprehensions in the added test case behaved differently:
The second one was incorrect: just like the first one, we should use the
casekeyword to make the pattern partial since we're in a for comprehension, but this information was lost when callingmakeCaseLambdaintypedFunctionValue. To fix this, we need to retrieve the attachment in the scrutinee (it was added there bymakeSelectorcalled frommakeCaseLambdacalled frommakeLambdacalled frommakeForinDesugar.scala).