Java parser: add support for JEP-445

[povder]

Starting a draft PR for #18584

[povder]

This is now ready for review. To run newly introduced compilation tests in CI, lampepfl/dotty-ci#24 needs to be released.

[smarter]

Thanks for working on this! Here are my thoughts after a first look at it, let me know if you'd like more guidance.

• For reference, while the JEP itself lacks some details, spec changes are available:

  • JLS changes: https://cr.openjdk.org/~gbierman/jep463/jep463-20231030/specs/implicitly-declared-classes-instance-main-methods-jls.html
  • JVMS changes: https://cr.openjdk.org/~gbierman/jep463/jep463-20231030/specs/implicitly-declared-classes-instance-main-methods-jvms.html

• Because all this stuff is still experimental, we need some mechanism to not enable it by default, normally we'd use @experimental but that only works for Scala code, so it's not clear to me what we should do here, adding a temporary -Y flag might be our best bet /cc @sjrd

• If I understand the spec correctly, user code should not be able to refer to an unnamed class by its compiler-synthesized name. Luckily we do have a flag to express this already: Invisible, so the JavaParser should set this flag, and we need tests to ensure it works properly here.

• The changes to the main method resolution in the JVMS will need to be reflected in a few places (I guess this could be handled in a separate PR since just being able to compile code would already be useful):

  • https://github.com/lampepfl/dotty/blob/main/compiler/src/dotty/tools/dotc/config/Platform.scala#L45-L49
  • https://github.com/lampepfl/dotty/blob/052bce44c6eccc7b6a0bf6cba3141e79a205e68a/compiler/src/dotty/tools/dotc/config/JavaPlatform.scala#L23-L28
  • https://github.com/lampepfl/dotty/blob/052bce44c6eccc7b6a0bf6cba3141e79a205e68a/compiler/src/dotty/tools/dotc/sbt/ExtractAPI.scala#L256-L259
  • It's possible sbt will need to be adjusted to correctly deal with the mainClass we feed it from ExtractAPI, but that's something we can worry about later as long as we keep this stuff experimental on our side.

[sjrd]

A -Y flag would be perfectly fine here. We don't have to deal with pollution of experimental products since the actual products are created by javac.

[Gedochao]

Note: JEP-445 has since been finalized in JEP-512, as delivered in JDK25.
That being said, @povder @smarter @hamzaremmal @sjrd, how much work would it be to bring this to completion? Does anyone mean to continue this PR in the near future?
Or should we close it for now and start again from scratch?

[lrytz]

See also my comment here: #23247 (comment)

[lrytz]

closed in favor of #23247