Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry Semantic Conventions groupId migrated #3198

Closed
wants to merge 1 commit into from
Closed

OpenTelemetry Semantic Conventions groupId migrated #3198

wants to merge 1 commit into from

Conversation

azthec
Copy link

@azthec azthec commented Oct 27, 2023

I noticed that we didn't automatically get prompted to version bump opentelemetry-semconv.

This should be the needed additions for the groupId migration

Relevant issue
Implementation PR

@fthomas
Copy link
Member

fthomas commented Oct 27, 2023

👍

Could you provide a link to an issue, pull request or some other documentation in the opentelemetry-semconv project that is about this groupId change?

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b65ce18) 91.07% compared to head (5c2d079) 91.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3198   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files         163      163           
  Lines        3406     3406           
  Branches      284      284           
=======================================
  Hits         3102     3102           
  Misses        304      304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azthec
Copy link
Author

azthec commented Oct 27, 2023

@fthomas I updated the description

@fthomas
Copy link
Member

fthomas commented Nov 3, 2023

I'm confused. If I look at https://repo1.maven.org/maven2/io/opentelemetry/opentelemetry-semconv/ and https://repo1.maven.org/maven2/io/opentelemetry/semconv/opentelemetry-semconv/, I see that the newest version from 2023-10-26 uses io.opentelemetry.semconv as groupId and it looks to me that the build also uses this groupId: https://github.com/open-telemetry/semantic-conventions-java/blob/8bbebbcf6d66230178dba60332375fb41d4f4e6c/build.gradle.kts#L37. But the migration in this PR would change the groupId from io.opentelemetry.semconv to io.opentelemetry. What am I missing?

@azthec azthec closed this Nov 3, 2023
@azthec azthec deleted the patch-1 branch November 3, 2023 09:20
@azthec
Copy link
Author

azthec commented Nov 3, 2023

It seems like they handle versioning differently for this, thanks anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants