Github actions + minimal install requirements + removed dependency on hardcoded path#21
Open
wschuell wants to merge 17 commits into
Open
Github actions + minimal install requirements + removed dependency on hardcoded path#21wschuell wants to merge 17 commits into
wschuell wants to merge 17 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I wrote the CI for github actions to test for the install process at each commit
(NB: python 3.8 is super old, you might consider trying to update the script to be compliant with more recent python+corresponding lib versions)
While doing so I created a minimal requirements install process, but still relying on both conda (or mamba) and pip. In your env declarations many elements were unsolvable (either failing on conda, installed via pip, or referring to local packages)
And I modified your definition of BABEL_LIBDIR to refer automatically to the corresponding activated environment rather than your home folder env :)