use docker/build-push-action #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francisdb
reviewed
Feb 15, 2023
|
The example at https://docs.docker.com/build/ci/github-actions/examples/#test-your-image-before-pushing-it also shows the user of |
francisdb
reviewed
Feb 17, 2023
.github/workflows/build.yml
Outdated
| @@ -98,6 +98,8 @@ jobs: | |||
| BASE_IMAGE_TAG=${{ matrix.baseImageTag }} | |||
| SBT_VERSION=${{ steps.get_sbt_version.outputs.VERSION }} | |||
| SCALA_VERSION=${{ matrix.scalaVersion }} | |||
| platforms: ${{ matrix.platforms }} | |||
There was a problem hiding this comment.
Since we only test on the current platform we don't need this
In the example on the docker website there is a comment that explains that the current platform build we be cached and reused in the push step.
There was a problem hiding this comment.
Looks like this is also not supported (see build result)
use cache fix
kijuky
force-pushed
the
feature/use-github-action
branch
from
6b73d6f to
8b0c2f6
Compare
|
Merging this one to see if it actually works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #166.
use docker/build-push-action.