Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update role for windows #27

Merged
merged 4 commits into from
Apr 11, 2022

Conversation

Tyneven
Copy link
Contributor

@Tyneven Tyneven commented Jan 24, 2022

I make Pull request for update your role for windows part.

First, I fix some errors in variables names (The First Commit)
Second, I add requirements.txt to install netaddr to use ipaddr filter in your role and add 1 variable for Windows. (The Last commit)

Finally, In my case i don't use DSC on my Windows Server. (The penultimate commit)
I added check and conditioning for the installation of the Feature DSC.

Check if DSC Feature is installed on Server and Set fact
I leave dsc module only if DSC is installed on server and if Powershell version 5 or higher is installed on Server
I add win_feature module if DSC isn't installed and If the Powershell version is lower than version 5 on Server

@Tyneven
Copy link
Contributor Author

Tyneven commented Jan 24, 2022

In Last commit, i fix exceeded backslash for registry in Windows
I delete backslash and it works fine.

It's a fix like #21 Pull Request.

@Tyneven
Copy link
Contributor Author

Tyneven commented Apr 11, 2022

Hi,
Please, can have a return on this pull request? :)

@sbaerlocher sbaerlocher merged commit f1cfef9 into sbaerlocher:master Apr 11, 2022
@sbaerlocher
Copy link
Owner

Thanks for the PR.

@Tyneven Tyneven deleted the update_role_for_windows branch April 15, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants