Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Mar 17, 2025

This PR contains the following updates:

Package Type Update Change
actions/checkout action major v4 -> v6
actions/download-artifact action major v4 -> v6
actions/setup-java action major v4 -> v5
actions/upload-artifact action major v4 -> v5
dorny/test-reporter action major v1 -> v2
github/codeql-action action major v3 -> v4

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

actions/checkout (actions/checkout)

v6

Compare Source

v5

Compare Source

actions/download-artifact (actions/download-artifact)

v6

Compare Source

v5

Compare Source

actions/setup-java (actions/setup-java)

v5

Compare Source

actions/upload-artifact (actions/upload-artifact)

v5

Compare Source

github/codeql-action (github/codeql-action)

v4

Compare Source


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2025

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

  167 files  ±0    167 suites  ±0   5m 24s ⏱️ + 1m 59s
1 446 tests ±0  1 407 ✅ ±0  39 💤 ±0  0 ❌ ±0 
2 826 runs  ±0  2 787 ✅ ±0  39 💤 ±0  0 ❌ ±0 

Results for commit 0972d41. ± Comparison against base commit cd77a0b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2025

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

  167 files  ±0    167 suites  ±0   9m 3s ⏱️ +38s
1 446 tests ±0  1 429 ✅ ±0  17 💤 ±0  0 ❌ ±0 
2 826 runs  ±0  2 809 ✅ ±0  17 💤 ±0  0 ❌ ±0 

Results for commit 0972d41. ± Comparison against base commit cd77a0b.

♻️ This comment has been updated with latest results.

@renovate renovate bot changed the title chore(deps): update dorny/test-reporter action to v2 chore(deps): update all github actions (major) Aug 6, 2025
@renovate renovate bot force-pushed the renovate/major-all-github-actions branch 2 times, most recently from ec78115 to f9b333d Compare August 11, 2025 15:16
@renovate renovate bot force-pushed the renovate/major-all-github-actions branch from f9b333d to fcb629d Compare August 21, 2025 05:58
@renovate renovate bot force-pushed the renovate/major-all-github-actions branch from fcb629d to 226f8cc Compare October 7, 2025 20:06
@renovate renovate bot force-pushed the renovate/major-all-github-actions branch from 226f8cc to 10e7c94 Compare October 25, 2025 00:04
@renovate renovate bot force-pushed the renovate/major-all-github-actions branch from 10e7c94 to fa61b71 Compare November 20, 2025 17:38
@0x6675636b796f75676974687562
Copy link
Member

Our smoke tests are failing, because year 2024 is hard-coded in our test data:

> Task :diktat-cli:test

DiktatSaveSmokeTest > smoke test #5() FAILED
    org.assertj.core.error.AssertJMultipleFailuresError at DiktatSaveSmokeTest.kt:48

DiktatSmokeTest > smoke test #5() FAILED
    org.opentest4j.AssertionFailedError at DiktatSmokeTest.kt:28

57 tests completed, 2 failed, 1 skipped

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.49%. Comparing base (cd77a0b) to head (0972d41).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1952      +/-   ##
============================================
- Coverage     77.95%   76.49%   -1.46%     
+ Complexity     2996     2995       -1     
============================================
  Files           134      134              
  Lines          8863     7917     -946     
  Branches       2119     2119              
============================================
- Hits           6909     6056     -853     
+ Misses          943      850      -93     
  Partials       1011     1011              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0x6675636b796f75676974687562
Copy link
Member

0x6675636b796f75676974687562 commented Nov 28, 2025

Now, the released version of Diktat (the "Run diKTat (release)" action) fails with

java.lang.NoSuchMethodError: 'void io.github.detekt.sarif4k.ToolComponent.<init>(io.github.detekt.sarif4k.ToolComponentReference, java.util.List, java.lang.String, java.lang.String, io.github.detekt.sarif4k.MultiformatMessageString, java.lang.String, java.util.Map, java.lang.String, java.lang.String, java.lang.Boolean, java.lang.String, java.lang.String, java.util.List, java.lang.String, java.lang.String, java.util.List, java.lang.String, java.lang.String, java.lang.String, io.github.detekt.sarif4k.PropertyBag, java.lang.String, java.util.List, java.lang.String, io.github.detekt.sarif4k.MultiformatMessageString, java.util.List, java.util.List, io.github.detekt.sarif4k.TranslationMetadata, java.lang.String, int, kotlin.jvm.internal.DefaultConstructorMarker)'
	at com.pinterest.ktlint.cli.reporter.sarif.SarifReporter.afterAll(SarifReporter.kt:95)
	at com.saveourtool.diktat.ktlint.ReporterV2Wrapper.afterAll(ReporterV2Wrapper.kt:20)
	at com.saveourtool.diktat.ktlint.KtLintUtilsKt$closeAfterAll$1.afterAll(KtLintUtils.kt:134)
	at com.saveourtool.diktat.ktlint.DiktatReporterImpl.doAfterAll(DiktatReporterImpl.kt:29)
	at com.saveourtool.diktat.ktlint.DiktatReporterImpl.doAfterAll(DiktatReporterImpl.kt:16)
	at com.saveourtool.diktat.util.DiktatProcessorListenerWrapper.afterAll(DiktatProcessorListenerWrapper.kt:66)
	at com.saveourtool.diktat.api.DiktatProcessorListener$Companion$union$1.doAfterAll(DiktatProcessorListener.kt:73)
	at com.saveourtool.diktat.api.DiktatProcessorListener$Companion$union$1.doAfterAll(DiktatProcessorListener.kt:63)
	at com.saveourtool.diktat.util.DiktatProcessorListenerWrapper.afterAll(DiktatProcessorListenerWrapper.kt:66)
	at com.saveourtool.diktat.api.DiktatBaseline$Companion$skipKnownErrors$1.doAfterAll(DiktatBaseline.kt:43)
	at com.saveourtool.diktat.api.DiktatBaseline$Companion$skipKnownErrors$1.doAfterAll(DiktatBaseline.kt:26)
	at com.saveourtool.diktat.util.DiktatProcessorListenerWrapper.afterAll(DiktatProcessorListenerWrapper.kt:66)
	at com.saveourtool.diktat.api.DiktatProcessorListener$Companion$union$1.doAfterAll(DiktatProcessorListener.kt:73)
	at com.saveourtool.diktat.api.DiktatProcessorListener$Companion$union$1.doAfterAll(DiktatProcessorListener.kt:63)
	at com.saveourtool.diktat.util.DiktatProcessorListenerWrapper.afterAll(DiktatProcessorListenerWrapper.kt:66)
	at com.saveourtool.diktat.api.DiktatProcessorListener$Companion$union$1.doAfterAll(DiktatProcessorListener.kt:73)
	at com.saveourtool.diktat.api.DiktatProcessorListener$Companion$union$1.doAfterAll(DiktatProcessorListener.kt:63)
	at com.saveourtool.diktat.util.DiktatProcessorListenerWrapper.afterAll(DiktatProcessorListenerWrapper.kt:66)
	at com.saveourtool.diktat.DiktatRunner$checkAll$1.invoke(DiktatRunner.kt:83)
	at com.saveourtool.diktat.DiktatRunner$checkAll$1.invoke(DiktatRunner.kt:74)
	at com.saveourtool.diktat.DiktatRunner.doRun(DiktatRunner.kt:28)
	at com.saveourtool.diktat.DiktatRunner.checkAll(DiktatRunner.kt:74)
	at com.saveourtool.diktat.plugin.gradle.tasks.DiktatCheckTask.doRun(DiktatCheckTask.kt:29)
	at com.saveourtool.diktat.plugin.gradle.tasks.DiktatTaskBase.doRun(DiktatTaskBase.kt:180)
	at com.saveourtool.diktat.plugin.gradle.tasks.DiktatTaskBase.run(DiktatTaskBase.kt:175)

This looks like a binary compatibility issue with Kotlin, because kotlin.jvm.internal.DefaultConstructorMarker is just a synthetic constructor argument, and detekt/sarif4k started using Kotlin 1.9 as of its own version 0.6.0 released in 2024.

The problem is not uncommon: see FasterXML/jackson-module-kotlin#279.

@renovate
Copy link
Contributor Author

renovate bot commented Nov 28, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants