[fixed-] split columns based on header positions#2996
Open
[fixed-] split columns based on header positions#2996
Conversation
Data values with internal spaces (e.g. "very very very light") could create false column splits when those spaces aligned across all rows. Now uses the first row (header) to determine column start positions, then finds column ends using data from all rows within those boundaries. Also fix putValue to use row[0] length (not row length) and to apply the j fallback before truncating value. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
columnize()to use the header (first row) to determine column start positions, preventing data with internal spaces (e.g. "very very very light") from creating false column splits. Closes [fixed] split columns based on header #2265.putValue()bug: was usingself.jbefore theself.j or len(...)fallback, andlen(row)instead oflen(row[0]).Test plan
visidata/tests/test_fixed_width.pytests/edit-fixed.vdx(load, edit, save fixed-width)load-fixedgolden unchangedpr2400golden (first column no longer has leading spaces from blank header — cosmetic, join logic unaffected)🤖 Generated with Claude Code